Bug 203540 - RenameField doesn't get NULL/NOT NULL correct

r,a=justdave

diff --git a/checksetup.pl b/checksetup.pl
index 7c44eaa6807e351d8c0b6e371a7aa150b9dd2e6a..f3228e804c6e17d2b62870738c4787ef8c1df06e 100755 (executable)
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -2120,7 +2120,7 @@ sub RenameField ($$$)
     if ($$ref[1] ne $newname) {
         print "Updating field $field in table $table ...\n";
         my $type = $$ref[1];
-        $type .= " NOT NULL" if $$ref[3];
+        $type .= " NOT NULL" if !$$ref[2];
         $dbh->do("ALTER TABLE $table
                   CHANGE $field
                   $newname $type");