Fix generic fmax, fmin sNaN handling (bug 20947).

Various fmax and fmin function implementations mishandle sNaN
arguments:

(a) When both arguments are NaNs, the return value should be a qNaN,
but sometimes it is an sNaN if at least one argument is an sNaN.

(b) Under TS 18661-1 semantics, if either argument is an sNaN then the
result should be a qNaN (whereas if one argument is a qNaN and the
other is not a NaN, the result should be the non-NaN argument).
Various implementations treat sNaNs like qNaNs here.

This patch fixes the generic implementations used in the absence of
architecture-specific versions.

Tested for mips64 and powerpc (together with testcases that I'll add
along with the x86_64 / x86 fixes).

	[BZ #20947]
	* math/s_fmax_template.c (M_DECL_FUNC (__fmax)): Add the arguments
	when either is a signaling NaN.
	* math/s_fmin_template.c (M_DECL_FUNC (__fmin)): Likewise.

diff --git a/ChangeLog b/ChangeLog
index ba42b5bd289682e0f2458fc10174e420e05696bb..c08b711d7a67676ec0f43628949cf241ec70f53b 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2016-12-14  Joseph Myers  <joseph@codesourcery.com>
 
+       [BZ #20947]
+       * math/s_fmax_template.c (M_DECL_FUNC (__fmax)): Add the arguments
+       when either is a signaling NaN.
+       * math/s_fmin_template.c (M_DECL_FUNC (__fmin)): Likewise.
+
        * bits/long-double.h: New file.
        * sysdeps/ieee754/ldbl-128/bits/long-double.h: Likewise.
        * sysdeps/ieee754/ldbl-96/bits/long-double.h: Likewise.

diff --git a/math/s_fmax_template.c b/math/s_fmax_template.c
index dea53d45f049fcd7d705d7243bbeb45913d7bc5f..e855b724bca518659d352dd413b46cf4dd7b1707 100644 (file)
--- a/math/s_fmax_template.c
+++ b/math/s_fmax_template.c
@@ -22,7 +22,14 @@
 FLOAT
 M_DECL_FUNC (__fmax) (FLOAT x, FLOAT y)
 {
-  return (isgreaterequal (x, y) || isnan (y)) ? x : y;
+  if (isgreaterequal (x, y))
+    return x;
+  else if (isless (x, y))
+    return y;
+  else if (issignaling (x) || issignaling (y))
+    return x + y;
+  else
+    return isnan (y) ? x : y;
 }
 
 declare_mgen_alias (__fmax, fmax);

diff --git a/math/s_fmin_template.c b/math/s_fmin_template.c
index b70989ac74b0d58bd2302eef9b3b6bd00c43550e..82009bb7e8013a5775d5d6b79ef222b209be3359 100644 (file)
--- a/math/s_fmin_template.c
+++ b/math/s_fmin_template.c
@@ -23,7 +23,14 @@
 FLOAT
 M_DECL_FUNC (__fmin) (FLOAT x, FLOAT y)
 {
-  return (islessequal (x, y) || isnan (y)) ? x : y;
+  if (islessequal (x, y))
+    return x;
+  else if (isgreater (x, y))
+    return y;
+  else if (issignaling (x) || issignaling (y))
+    return x + y;
+  else
+    return isnan (y) ? x : y;
 }
 declare_mgen_alias (__fmin, fmin);