]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
powerpc/pseries/vas: Pass hw_cpu_id to node associativity HCALL
authorHaren Myneni <haren@linux.ibm.com>
Thu, 29 Sep 2022 01:57:33 +0000 (18:57 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:58:04 +0000 (09:58 +0200)
[ Upstream commit f3e5d9e53e74d77e711a2c90a91a8b0836a9e0b3 ]

Generally the hypervisor decides to allocate a window on different
VAS instances. But if user space wishes to allocate on the current VAS
instance where the process is executing, the kernel has to pass
associativity domain IDs to allocate VAS window HCALL.

To determine the associativity domain IDs for the current CPU,
smp_processor_id() is passed to node associativity HCALL which may
return H_P2 (-55) error during DLPAR CPU event. This is because Linux
CPU numbers (smp_processor_id()) are not the same as the hypervisor's
view of CPU numbers.

Fix the issue by passing hard_smp_processor_id() with
VPHN_FLAG_VCPU flag (PAPR 14.11.6.1 H_HOME_NODE_ASSOCIATIVITY).

Fixes: b22f2d88e435 ("powerpc/pseries/vas: Integrate API with open/close windows")
Reviewed-by: Nathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: Haren Myneni <haren@linux.ibm.com>
[mpe: Update change log to mention Linux vs HV CPU numbers]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/55380253ea0c11341824cd4c0fc6bbcfc5752689.camel@linux.ibm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/powerpc/platforms/pseries/vas.c

index 500a1fc4a1d7d524191bbf0126673d497f4f8635..b2a32f8a837acb0eb64146c5c28f0b54cc43fa99 100644 (file)
@@ -332,7 +332,7 @@ static struct vas_window *vas_allocate_window(int vas_id, u64 flags,
                 * So no unpacking needs to be done.
                 */
                rc = plpar_hcall9(H_HOME_NODE_ASSOCIATIVITY, domain,
-                                 VPHN_FLAG_VCPU, smp_processor_id());
+                                 VPHN_FLAG_VCPU, hard_smp_processor_id());
                if (rc != H_SUCCESS) {
                        pr_err("H_HOME_NODE_ASSOCIATIVITY error: %d\n", rc);
                        goto out;