]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
prop250: Plug TorVersion memleak in disk_state_reset().
authorGeorge Kadianakis <desnacked@riseup.net>
Mon, 4 Jul 2016 09:28:28 +0000 (12:28 +0300)
committerGeorge Kadianakis <desnacked@riseup.net>
Mon, 4 Jul 2016 14:42:25 +0000 (17:42 +0300)
src/or/shared_random_state.c

index 73df9c43fb76d08664eaf42dfb79d9fcb82d8681..7d34334437bb5948943e560a155e273be48b1093 100644 (file)
@@ -597,10 +597,16 @@ disk_state_put_srv_line(const sr_srv_t *srv, config_line_t *line)
 static void
 disk_state_reset(void)
 {
+  /* Free allocated memory */
   config_free_lines(sr_disk_state->Commit);
   config_free_lines(sr_disk_state->SharedRandValues);
   config_free_lines(sr_disk_state->ExtraLines);
+  tor_free(sr_disk_state->TorVersion);
+
+  /* Clean up the struct */
   memset(sr_disk_state, 0, sizeof(*sr_disk_state));
+
+  /* Reset it with useful data */
   sr_disk_state->magic_ = SR_DISK_STATE_MAGIC;
   sr_disk_state->TorVersion = tor_strdup(get_version());
 }