]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: accel: adxl345: simplify reading the FIFO
authorLothar Rubusch <l.rubusch@gmail.com>
Wed, 2 Jul 2025 23:03:09 +0000 (23:03 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 14 Jul 2025 18:20:50 +0000 (19:20 +0100)
Bulk FIFO reading can be streamlined by eliminating redundant variables and
simplifying the process of reading x-, y-, and z-axis measurement sets.

This is a refactoring change with no expected impact on functionality.

Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
Link: https://patch.msgid.link/20250702230315.19297-3-l.rubusch@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/adxl345_core.c

index 6c437d7a59edbe0666b6d3f94ffc3cfa3330e62e..b7dfd0007aa068daefc8cd6ec627655303c6d198 100644 (file)
@@ -885,15 +885,12 @@ static int adxl345_get_samples(struct adxl345_state *st)
  */
 static int adxl345_fifo_transfer(struct adxl345_state *st, int samples)
 {
-       size_t count;
        int i, ret = 0;
 
-       /* count is the 3x the fifo_buf element size, hence 6B */
-       count = sizeof(st->fifo_buf[0]) * ADXL345_DIRS;
        for (i = 0; i < samples; i++) {
-               /* read 3x 2 byte elements from base address into next fifo_buf position */
                ret = regmap_bulk_read(st->regmap, ADXL345_REG_XYZ_BASE,
-                                      st->fifo_buf + (i * count / 2), count);
+                                      st->fifo_buf + (i * ADXL345_DIRS),
+                                      sizeof(st->fifo_buf[0]) * ADXL345_DIRS);
                if (ret)
                        return ret;