]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Forbid rx/tx_queue_size change explicitly
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 31 Aug 2017 09:33:06 +0000 (11:33 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 1 Sep 2017 07:50:44 +0000 (09:50 +0200)
https://bugzilla.redhat.com/show_bug.cgi?id=1484230

When updating a virtio enabled vNIC and trying to change either
of rx_queue_size or tx_queue_size success is reported although no
operation is actually performed. Moreover, there's no way how to
change these on the fly. This is due to way we check for changes:
explicitly for each struct member. Therefore it's easy to miss
one.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_hotplug.c

index 4be0f546ca21b192016de2874bb1e1b06c2e2db8..9611df517aa8240f8bcaa4de6e9343003d0a4aa7 100644 (file)
@@ -3067,6 +3067,8 @@ qemuDomainChangeNet(virQEMUDriverPtr driver,
          olddev->driver.virtio.ioeventfd != newdev->driver.virtio.ioeventfd ||
          olddev->driver.virtio.event_idx != newdev->driver.virtio.event_idx ||
          olddev->driver.virtio.queues != newdev->driver.virtio.queues ||
+         olddev->driver.virtio.rx_queue_size != newdev->driver.virtio.rx_queue_size ||
+         olddev->driver.virtio.tx_queue_size != newdev->driver.virtio.tx_queue_size ||
          olddev->driver.virtio.host.csum != newdev->driver.virtio.host.csum ||
          olddev->driver.virtio.host.gso != newdev->driver.virtio.host.gso ||
          olddev->driver.virtio.host.tso4 != newdev->driver.virtio.host.tso4 ||