]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: Rename virCPUDefUpdateFeatureInternal
authorJiri Denemark <jdenemar@redhat.com>
Thu, 19 Nov 2020 17:24:01 +0000 (18:24 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Tue, 24 Nov 2020 19:13:23 +0000 (20:13 +0100)
The function is supposed to add a feature to a CPU definition, let's
name it virCPUDefAddFeatureInternal. The behavior in case the feature is
already present in the CPU def is configurable and we will soon add a
new option to not do anything in that case, which wouldn't really work
well with the current *Update* name.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Tim Wiederhake <twiederh@redhat.com>
src/conf/cpu_conf.c

index 5cf7716b12d15625e7445844bfb188f9b1c89c61..55a7925d8adec5d7a842eb0328f1fcbe348dedfc 100644 (file)
@@ -858,10 +858,10 @@ virCPUDefFormatBuf(virBufferPtr buf,
 }
 
 static int
-virCPUDefUpdateFeatureInternal(virCPUDefPtr def,
-                               const char *name,
-                               int policy,
-                               bool update)
+virCPUDefAddFeatureInternal(virCPUDefPtr def,
+                            const char *name,
+                            int policy,
+                            bool update)
 {
     virCPUFeatureDefPtr feat;
 
@@ -898,7 +898,7 @@ virCPUDefUpdateFeature(virCPUDefPtr def,
                        const char *name,
                        int policy)
 {
-    return virCPUDefUpdateFeatureInternal(def, name, policy, true);
+    return virCPUDefAddFeatureInternal(def, name, policy, true);
 }
 
 int
@@ -906,7 +906,7 @@ virCPUDefAddFeature(virCPUDefPtr def,
                     const char *name,
                     int policy)
 {
-    return virCPUDefUpdateFeatureInternal(def, name, policy, false);
+    return virCPUDefAddFeatureInternal(def, name, policy, false);
 }