daemon: nitpicks about the parent commit

diff --git a/daemon/engine.c b/daemon/engine.c
index 54fdf2a0efafe2acf76bd405d22ae9631e403631..a1d26f578bfa8464d72f46e8bd5fb8a757bb84c5 100644 (file)
--- a/daemon/engine.c
+++ b/daemon/engine.c
@@ -369,7 +369,7 @@ static int l_map(lua_State *L)
                /* Read response */
                uint32_t rlen = 0;
                if (read(fd, &rlen, sizeof(rlen)) == sizeof(rlen)) {
-                       expr_checked(rlen < UINT_MAX);
+                       expr_checked(rlen < UINT32_MAX);
                        auto_free char *rbuf = malloc(rlen + 1);
                        expr_checked(rbuf != NULL);
                        expr_checked(read(fd, rbuf, rlen) == rlen);

diff --git a/daemon/network.c b/daemon/network.c
index 5ae9a7f568fef75d41ddba9fb1bc79b667e40390..db04fedff41efa9bdaaac4726f1985e09f331bd3 100644 (file)
--- a/daemon/network.c
+++ b/daemon/network.c
@@ -143,7 +143,7 @@ static int open_endpoint(struct network *net, struct endpoint *ep, struct sockad
                        return kr_error(ENOMEM);
                }
                memset(ep->udp, 0, sizeof(*ep->udp));
-               handle_init(udp, net->loop, ep->udp, sa->sa_family);
+               handle_init(udp, net->loop, ep->udp, sa->sa_family); /* can return! */
                ret = udp_bind(ep->udp, sa);
                if (ret != 0) {
                        return ret;
@@ -156,7 +156,7 @@ static int open_endpoint(struct network *net, struct endpoint *ep, struct sockad
                        return kr_error(ENOMEM);
                }
                memset(ep->tcp, 0, sizeof(*ep->tcp));
-               handle_init(tcp, net->loop, ep->tcp, sa->sa_family);
+               handle_init(tcp, net->loop, ep->tcp, sa->sa_family); /* can return! */
                if (flags & NET_TLS) {
                        ret = tcp_bind_tls(ep->tcp, sa);
                        ep->flags |= NET_TLS;