rust: fix clippy lints for unneeded reference in debug code

diff --git a/rust/src/dns/lua.rs b/rust/src/dns/lua.rs
index e0e0803f6f789c46594cb2b81ad74ae7ca5633a9..29746231a392cf4145051e78a85ca329806b68ec 100644 (file)
--- a/rust/src/dns/lua.rs
+++ b/rust/src/dns/lua.rs
@@ -170,7 +170,7 @@ pub extern "C" fn rs_dns_lua_get_answer_table(clua: &mut CLuaState,
                 DNSRData::A(ref bytes) | DNSRData::AAAA(ref bytes) => {
                     if !bytes.is_empty() {
                         lua.pushstring("addr");
-                        lua.pushstring(&dns_print_addr(&bytes));
+                        lua.pushstring(&dns_print_addr(bytes));
                         lua.settable(-3);
                     }
                 },
@@ -183,7 +183,7 @@ pub extern "C" fn rs_dns_lua_get_answer_table(clua: &mut CLuaState,
                 DNSRData::Unknown(ref bytes) => {
                     if !bytes.is_empty() {
                         lua.pushstring("addr");
-                        lua.pushstring(&String::from_utf8_lossy(&bytes));
+                        lua.pushstring(&String::from_utf8_lossy(bytes));
                         lua.settable(-3);
                     }
                 },

diff --git a/rust/src/nfs/nfs4.rs b/rust/src/nfs/nfs4.rs
index 8de5bcb90aff11bcca80a9cef864f0c4c2d25854..45081e4e8c15d437908d2e7d490b73137f486343 100644 (file)
--- a/rust/src/nfs/nfs4.rs
+++ b/rust/src/nfs/nfs4.rs
@@ -184,11 +184,11 @@ impl NFSState {
                     }
                 }
                 &Nfs4RequestContent::Open(ref rd) => {
-                    SCLogDebug!("OPENv4: {}", String::from_utf8_lossy(&rd.filename));
+                    SCLogDebug!("OPENv4: {}", String::from_utf8_lossy(rd.filename));
                     xidmap.file_name = rd.filename.to_vec();
                 }
                 &Nfs4RequestContent::Lookup(ref rd) => {
-                    SCLogDebug!("LOOKUPv4: {}", String::from_utf8_lossy(&rd.filename));
+                    SCLogDebug!("LOOKUPv4: {}", String::from_utf8_lossy(rd.filename));
                     xidmap.file_name = rd.filename.to_vec();
                 }
                 &Nfs4RequestContent::Write(ref rd) => {
@@ -225,9 +225,9 @@ impl NFSState {
                 &Nfs4RequestContent::SetClientId(ref _rd) => {
                     SCLogDebug!(
                         "SETCLIENTIDv4: client id {} r_netid {} r_addr {}",
-                        String::from_utf8_lossy(&_rd.client_id),
-                        String::from_utf8_lossy(&_rd.r_netid),
-                        String::from_utf8_lossy(&_rd.r_addr)
+                        String::from_utf8_lossy(_rd.client_id),
+                        String::from_utf8_lossy(_rd.r_netid),
+                        String::from_utf8_lossy(_rd.r_addr)
                     );
                 }
                 &_ => {}
@@ -325,7 +325,7 @@ impl NFSState {
 
                         for d in &rd.listing {
                             if let &Some(ref _d) = d {
-                                SCLogDebug!("READDIRv4: dir {}", String::from_utf8_lossy(&_d.name));
+                                SCLogDebug!("READDIRv4: dir {}", String::from_utf8_lossy(_d.name));
                             }
                         }
                     }

diff --git a/rust/src/smb/smb.rs b/rust/src/smb/smb.rs
index dfa066d47443428e134ff2b5910f31f8033ba74a..042fdf72d97bdaa6731a5f8088395050e8a18531 100644 (file)
--- a/rust/src/smb/smb.rs
+++ b/rust/src/smb/smb.rs
@@ -1057,7 +1057,7 @@ impl SMBState {
                     Ok("suricata::dcerpc") => ("unknown", true),
                     Err(_) => ("MALFORMED", false),
                     Ok(&_) => {
-                        SCLogDebug!("don't know {}", String::from_utf8_lossy(&n));
+                        SCLogDebug!("don't know {}", String::from_utf8_lossy(n));
                         ("UNKNOWN", false)
                     },
                 }