go: Exclude vcs files when installing deps

Because our clones use the host git, on (say) Ubuntu 18.04, the local
git directories acquire perl scripts such as fsmonitor-watchman.sample.
During packaging, this leads to failures:

  ERROR: go-hsperfdata-1.0.3+gitAUTOINC+b58598ac84-r0 do_package_qa: QA Issue: /usr/lib/go/pkg/dep/sources/https---github.com-nsf-termbox--go/.git/hooks/fsmonitor-watchman.sample contained in package go-hsperfdata-staticdev requires /usr/bin/perl, but no providers found in RDEPENDS_go-hsperfdata-staticdev? [file-rdeps]
  ERROR: go-hsperfdata-1.0.3+gitAUTOINC+b58598ac84-r0 do_package_qa: QA run found fatal errors. Please consider fixing them.
  ERROR: go-hsperfdata-1.0.3+gitAUTOINC+b58598ac84-r0 do_package_qa:
  ERROR: go-hsperfdata-1.0.3+gitAUTOINC+b58598ac84-r0 do_package_qa: Function failed: do_package_qa

(From OE-Core rev: 2ee246524ab881d57d8aac204f671215a25a58d3)

Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass
index 7f5e8b99bfc75611a075490b10b232b0ddfd95b4..b6d9372c5696f9d54e4a02a7a0f5e3e1b7c4114a 100644 (file)
--- a/meta/classes/go.bbclass
+++ b/meta/classes/go.bbclass
@@ -130,7 +130,7 @@ go_do_install() {
        install -d ${D}${libdir}/go/src/${GO_IMPORT}
        tar -C ${S}/src/${GO_IMPORT} -cf - --exclude-vcs --exclude '*.test' --exclude 'testdata' . | \
                tar -C ${D}${libdir}/go/src/${GO_IMPORT} --no-same-owner -xf -
-       tar -C ${B} -cf - pkg | tar -C ${D}${libdir}/go --no-same-owner -xf -
+       tar -C ${B} -cf - --exclude-vcs pkg | tar -C ${D}${libdir}/go --no-same-owner -xf -
 
        if [ -n "`ls ${B}/${GO_BUILD_BINDIR}/`" ]; then
                install -d ${D}${bindir}