]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tick/nohz: avoid showing '(null)' if nohz_full= not set
authorAaron Tomlin <atomlin@atomlin.com>
Sat, 11 Oct 2025 01:18:30 +0000 (21:18 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Nov 2025 14:20:49 +0000 (15:20 +0100)
In the context of CONFIG_NO_HZ_FULL=y, tick_nohz_full_mask (of type
cpumask_var_t) is initialised to 0. Memory is only allocated to the cpumask
data structure, in tick_nohz_full_setup(), when Linux kernel boot-time
parameter "nohz_full=" is correctly specified (see housekeeping_setup()).
If "nohz_full=" is not set and an attempt is made to read
/sys/devices/system/cpu/nohz_full, '(null)' can be displayed:

    ❯ cat /sys/devices/system/cpu/nohz_full
    (null)

This patch changes the output to print a newline (or 0x0A) instead of
'(null)', making it consistent with print_cpus_isolated() behaviour.

Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>
Link: https://patch.msgid.link/20251011011830.6670-3-atomlin@atomlin.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/cpu.c

index c792ec66462d85b7bad37582f9409355645c536a..e3cb47eae982288b4377d4d16dfc2012c6d1b6a6 100644 (file)
@@ -305,7 +305,10 @@ static ssize_t nohz_full_show(struct device *dev,
                                    struct device_attribute *attr,
                                    char *buf)
 {
-       return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(tick_nohz_full_mask));
+       if (cpumask_available(tick_nohz_full_mask))
+               return sysfs_emit(buf, "%*pbl\n",
+                                 cpumask_pr_args(tick_nohz_full_mask));
+       return sysfs_emit(buf, "\n");
 }
 static DEVICE_ATTR_RO(nohz_full);
 #endif