]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: dac: ad5360: use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Mon, 1 Sep 2025 13:57:25 +0000 (21:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 19 Oct 2025 14:33:50 +0000 (16:33 +0200)
commit f9381ece76de999a2065d5b4fdd87fa17883978c upstream.

Change the 'ret' variable in ad5360_update_ctrl() from unsigned int to
int, as it needs to store either negative error codes or zero returned
by ad5360_write_unlocked().

Fixes: a3e2940c24d3 ("staging:iio:dac: Add AD5360 driver")
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Link: https://patch.msgid.link/20250901135726.17601-2-rongqianfeng@vivo.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/dac/ad5360.c

index e0b7f658d61196c191ade50dcba22d7ec2d5cc49..cf9cf90cd6e2766c6e7e50e88866b9a54b9b8e71 100644 (file)
@@ -262,7 +262,7 @@ static int ad5360_update_ctrl(struct iio_dev *indio_dev, unsigned int set,
        unsigned int clr)
 {
        struct ad5360_state *st = iio_priv(indio_dev);
-       unsigned int ret;
+       int ret;
 
        mutex_lock(&st->lock);