]> git.ipfire.org Git - thirdparty/grub.git/commitdiff
core: avoid NULL derefrence in grub_divmod64s
authorAndrei Borzenkov <arvidjaar@gmail.com>
Mon, 6 Apr 2015 16:25:02 +0000 (19:25 +0300)
committerAndrei Borzenkov <arvidjaar@gmail.com>
Mon, 6 Apr 2015 16:30:51 +0000 (19:30 +0300)
It can be called with NULL for third argument.  grub_divmod32* for
now are called only from within wrappers, so skip check.

Reported-By: Michael Zimmermann <sigmaepsilon92@gmail.com>
grub-core/lib/division.c

index 920a79f18b7a7180bc5bcf18987c043b1df56687..35606fea793c92235a70d09834833631a341a389 100644 (file)
@@ -50,7 +50,8 @@ grub_divmod64s (grub_int64_t n,
       q = -q;
     }
   /* Now: n = d * q + r  */
-  *ro = r;
+  if (ro)
+    *ro = r;
   return q;
 }