]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Fix hanging of test_external_cf_quiche
authorEugene Syromiatnikov <esyr@openssl.org>
Wed, 30 Jul 2025 13:55:14 +0000 (15:55 +0200)
committerEugene Syromiatnikov <esyr@openssl.org>
Wed, 30 Jul 2025 14:04:55 +0000 (16:04 +0200)
The commit "Remove HARNESS_OSSL_PREFIX manipulation in the test harness"
forced all the output to be processed by the test harness, which means
that any process that keeps the stdout FD open prevents the run() call
from finishing, as was the case in the test_external_cf_quiche test that
ran quiche server in the background, but retaining the std{in,out,err}
descriptors.  Avoid that by explicitly redirecting them to a log file.

Reported-by: Tomas Mraz <tomas@openssl.org>
Fixes: 70c05fcde53cf "Remove HARNESS_OSSL_PREFIX manipulation in the test harness"
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28125)

test/recipes/95-test_external_cf_quiche_data/quiche-server.sh

index 4ed566a575293d6ac676231f97db436928ce8edb..088939b8c0c2ea9d07531b53d081f5344aeb2bc8 100755 (executable)
@@ -24,6 +24,6 @@ test -d "$QUICHE_TARGET_PATH" || exit 1
 
 "$QUICHE_TARGET_PATH/debug/quiche-server" --cert "$SRCTOP/test/certs/servercert.pem" \
     --key "$SRCTOP/test/certs/serverkey.pem" --disable-gso \
-    --http-version HTTP/0.9 --root "$SRCTOP" --no-grease --disable-hystart &
+    --http-version HTTP/0.9 --root "$SRCTOP" --no-grease --disable-hystart > quiche_server_log 2>&1 &
 
 echo $! >server.pid