]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests/bpf: Fix endianness issue in sk_assign
authorIlya Leoshkevich <iii@linux.ibm.com>
Tue, 15 Sep 2020 11:38:15 +0000 (13:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:07:40 +0000 (10:07 +0100)
[ Upstream commit b6ed6cf4a3acdeab9aed8e0a524850761ec9b152 ]

server_map's value size is 8, but the test tries to put an int there.
This sort of works on x86 (unless followed by non-0), but hard fails on
s390.

Fix by using __s64 instead of int.

Fixes: 2d7824ffd25c ("selftests: bpf: Add test for sk_assign")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/20200915113815.3768217-1-iii@linux.ibm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/bpf/prog_tests/sk_assign.c

index 47fa04adc1471f7218265a877fd67d74429fdca4..21c2d265c3e8e554ee7384c43a49a162aed049f0 100644 (file)
@@ -265,7 +265,7 @@ void test_sk_assign(void)
                TEST("ipv6 udp port redir", AF_INET6, SOCK_DGRAM, false),
                TEST("ipv6 udp addr redir", AF_INET6, SOCK_DGRAM, true),
        };
-       int server = -1;
+       __s64 server = -1;
        int server_map;
        int self_net;