perf genelf: Switch from SHA-1 to BLAKE2s for build ID generation

Recent patches [1] [2] added an implementation of SHA-1 to perf and made
it be used for build ID generation.

I had understood the choice of SHA-1, which is a legacy algorithm, to be
for backwards compatibility.

It turns out, though, that there's no backwards compatibility
requirement here other than the size of the build ID field, which is
fixed at 20 bytes.  Not only did the hash algorithm already change (from
MD5 to SHA-1), but the inputs to the hash changed too: from 'load_addr
|| code' to just 'code', and now again to 'code || symtab || strsym'
[3].  Different linkers generate different build IDs, with the LLVM
linker using BLAKE3 hashes for example [4].

Therefore, we might as well switch to a more modern algorithm.  Let's go
with BLAKE2s.  It's faster than SHA-1, isn't cryptographically broken,
is easier to implement than BLAKE3, and the kernel's implementation in
lib/crypto/blake2s.c is easily borrowed.  It also natively supports
variable-length hashes, so it can directly produce the needed 20 bytes.

Also make the following additional improvements:

- Hash the three inputs incrementally, so they don't all have to be
  concatenated into one buffer.

- Add tag/length prefixes to each of the three inputs, so that distinct
  input tuples reliably result in distinct hashes.

[1] https://lore.kernel.org/linux-perf-users/20250521225307.743726-1-yuzhuo@google.com/
[2] https://lore.kernel.org/linux-perf-users/20250625202311.23244-1-ebiggers@kernel.org/
[3] https://lore.kernel.org/linux-perf-users/20251125080748.461014-1-namhyung@kernel.org/
[4] https://github.com/llvm/llvm-project/commit/d3e5b6f7539b86995aef6e2075c1edb3059385ce

Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Tested-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Fangrui Song <maskray@sourceware.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Pablo Galindo <pablogsal@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
index a1cd5196f4ec8f88f8da3b37c492001e0cb2e0d0..14882def9704c66d014c6fec96b2abb91d88ecbc 100644 (file)
--- a/tools/perf/util/genelf.c
+++ b/tools/perf/util/genelf.c
@@ -18,8 +18,8 @@
 #include <dwarf.h>
 #endif
 
+#include "blake2s.h"
 #include "genelf.h"
-#include "sha1.h"
 #include "../util/jitdump.h"
 #include <linux/compiler.h>
 
@@ -51,7 +51,7 @@ static char shd_string_table[] = {
 static struct buildid_note {
        Elf_Note desc;          /* descsz: size of build-id, must be multiple of 4 */
        char     name[4];       /* GNU\0 */
-       u8       build_id[SHA1_DIGEST_SIZE];
+       u8       build_id[20];
 } bnote;
 
 static Elf_Sym symtab[]={
@@ -152,9 +152,28 @@ jit_add_eh_frame_info(Elf *e, void* unwinding, uint64_t unwinding_header_size,
        return 0;
 }
 
+enum {
+       TAG_CODE = 0,
+       TAG_SYMTAB = 1,
+       TAG_STRSYM = 2,
+};
+
+/*
+ * Update the hash using the given data, also prepending a (tag, len) prefix to
+ * ensure that distinct input tuples reliably result in distinct hashes.
+ */
+static void blake2s_update_tagged(struct blake2s_ctx *ctx, int tag,
+                                 const void *data, size_t len)
+{
+       u64 prefix = ((u64)tag << 56) | len;
+
+       blake2s_update(ctx, (const u8 *)&prefix, sizeof(prefix));
+       blake2s_update(ctx, data, len);
+}
+
 /*
  * fd: file descriptor open for writing for the output file
- * load_addr: code load address (could be zero, just used for buildid)
+ * load_addr: code load address (could be zero)
  * sym: function name (for native code - used as the symbol)
  * code: the native code
  * csize: the code size in bytes
@@ -173,8 +192,7 @@ jit_write_elf(int fd, uint64_t load_addr __maybe_unused, const char *sym,
        Elf_Shdr *shdr;
        uint64_t eh_frame_base_offset;
        char *strsym = NULL;
-       void *build_id_data = NULL, *tmp;
-       int build_id_data_len;
+       struct blake2s_ctx ctx;
        int symlen;
        int retval = -1;
 
@@ -253,13 +271,8 @@ jit_write_elf(int fd, uint64_t load_addr __maybe_unused, const char *sym,
        shdr->sh_flags = SHF_EXECINSTR | SHF_ALLOC;
        shdr->sh_entsize = 0;
 
-       build_id_data = malloc(csize);
-       if (build_id_data == NULL) {
-               warnx("cannot allocate build-id data");
-               goto error;
-       }
-       memcpy(build_id_data, code, csize);
-       build_id_data_len = csize;
+       blake2s_init(&ctx, sizeof(bnote.build_id));
+       blake2s_update_tagged(&ctx, TAG_CODE, code, csize);
 
        /*
         * Setup .eh_frame_hdr and .eh_frame
@@ -344,14 +357,7 @@ jit_write_elf(int fd, uint64_t load_addr __maybe_unused, const char *sym,
        shdr->sh_entsize = sizeof(Elf_Sym);
        shdr->sh_link = unwinding ? 6 : 4; /* index of .strtab section */
 
-       tmp = realloc(build_id_data, build_id_data_len + sizeof(symtab));
-       if (tmp == NULL) {
-               warnx("cannot allocate build-id data");
-               goto error;
-       }
-       memcpy(tmp + build_id_data_len, symtab, sizeof(symtab));
-       build_id_data = tmp;
-       build_id_data_len += sizeof(symtab);
+       blake2s_update_tagged(&ctx, TAG_SYMTAB, symtab, sizeof(symtab));
 
        /*
         * setup symbols string table
@@ -395,14 +401,7 @@ jit_write_elf(int fd, uint64_t load_addr __maybe_unused, const char *sym,
        shdr->sh_flags = 0;
        shdr->sh_entsize = 0;
 
-       tmp = realloc(build_id_data, build_id_data_len + symlen);
-       if (tmp == NULL) {
-               warnx("cannot allocate build-id data");
-               goto error;
-       }
-       memcpy(tmp + build_id_data_len, strsym, symlen);
-       build_id_data = tmp;
-       build_id_data_len += symlen;
+       blake2s_update_tagged(&ctx, TAG_STRSYM, strsym, symlen);
 
        /*
         * setup build-id section
@@ -422,7 +421,7 @@ jit_write_elf(int fd, uint64_t load_addr __maybe_unused, const char *sym,
        /*
         * build-id generation
         */
-       sha1(build_id_data, build_id_data_len, bnote.build_id);
+       blake2s_final(&ctx, bnote.build_id);
        bnote.desc.namesz = sizeof(bnote.name); /* must include 0 termination */
        bnote.desc.descsz = sizeof(bnote.build_id);
        bnote.desc.type   = NT_GNU_BUILD_ID;
@@ -467,7 +466,6 @@ error:
        (void)elf_end(e);
 
        free(strsym);
-       free(build_id_data);
 
        return retval;
 }