]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: blockjob: Log blockjobs which are dropped when untracked by qemu
authorPeter Krempa <pkrempa@redhat.com>
Tue, 26 Nov 2019 13:14:54 +0000 (14:14 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 27 Nov 2019 14:59:33 +0000 (15:59 +0100)
Since we don't know what happened to the job we can't do much about it
but we can at least log that this happened.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
src/qemu/qemu_blockjob.c

index 818e36435c1ec3c4570e2cd77275caf94d0a4306..b83d681f0664e150c222941803254f77d763710d 100644 (file)
@@ -501,8 +501,10 @@ qemuBlockJobRefreshJobs(virQEMUDriverPtr driver,
 
     /* remove data for job which qemu didn't report (the algorithm is
      * inefficient, but the possibility of such jobs is very low */
-    while ((job = virHashSearch(priv->blockjobs, qemuBlockJobRefreshJobsFindInactive, NULL, NULL)))
+    while ((job = virHashSearch(priv->blockjobs, qemuBlockJobRefreshJobsFindInactive, NULL, NULL))) {
+        VIR_WARN("dropping blockjob '%s' untracked by qemu", job->name);
         qemuBlockJobUnregister(job, vm);
+    }
 
     ret = 0;