]> git.ipfire.org Git - thirdparty/vala.git/commitdiff
Don't warn about unused internal methods which are meant to be visible on DBus
authorRico Tzschichholz <ricotz@ubuntu.com>
Tue, 13 Feb 2018 09:37:03 +0000 (10:37 +0100)
committerRico Tzschichholz <ricotz@ubuntu.com>
Tue, 13 Feb 2018 09:37:03 +0000 (10:37 +0100)
https://bugzilla.gnome.org/show_bug.cgi?id=593902

vala/valaflowanalyzer.vala

index 122e58d7f0bb45aa9630f6d1ff3d53bb7e17fadb..853eae73dabb9641c68db689ec3bfde2fadb3b1d 100644 (file)
@@ -170,6 +170,9 @@ public class Vala.FlowAnalyzer : CodeVisitor {
                    && !(m is CreationMethod)) {
                        if (!m.is_private_symbol () && (context.internal_header_filename != null || context.use_fast_vapi)) {
                                // do not warn if internal member may be used outside this compilation unit
+                       } else if (m.parent_symbol != null && m.parent_symbol.get_attribute ("DBus") != null
+                           && m.get_attribute_bool ("DBus", "visible", true)) {
+                               // do not warn if internal member is a visible DBus method
                        } else {
                                Report.warning (m.source_reference, "method `%s' never used".printf (m.get_full_name ()));
                        }