]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Sun, 19 Mar 2023 12:33:29 +0000 (12:33 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 May 2023 14:11:09 +0000 (23:11 +0900)
[ Upstream commit 9ef70d0130f282638b28cfce24222f71ada00c9c ]

pcs_get_state() implementations are not supposed to alter an_enabled.
Remove this assignment.

Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://lore.kernel.org/r/E1pdsE5-00Dl2l-8F@rmk-PC.armlinux.org.uk
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/dsa/qca/qca8k-8xxx.c

index 2f224b166bbb32dc583ed9f65a41cf72742afc04..f7944fe2e0ba727ab4e857a6a72777c7dc73d3bc 100644 (file)
@@ -1427,7 +1427,6 @@ static void qca8k_pcs_get_state(struct phylink_pcs *pcs,
 
        state->link = !!(reg & QCA8K_PORT_STATUS_LINK_UP);
        state->an_complete = state->link;
-       state->an_enabled = !!(reg & QCA8K_PORT_STATUS_LINK_AUTO);
        state->duplex = (reg & QCA8K_PORT_STATUS_DUPLEX) ? DUPLEX_FULL :
                                                           DUPLEX_HALF;