lib-smtp: server: Fix copying xclient_extensions settings

smtp_server_connection didn't properly copy the xclient_extensions settings
from the smtp_server. In fact it did the opposite of recreating the server
settings using the connection pool. Later on after the connection was freed
and another connection created this could result in crashes.

diff --git a/src/lib-smtp/smtp-server-connection.c b/src/lib-smtp/smtp-server-connection.c
index 5e0a14854836d88727eeb62840e16db41e447cd1..1bfb72859145a814013549a09e39ded942b6c2dc 100644 (file)
--- a/src/lib-smtp/smtp-server-connection.c
+++ b/src/lib-smtp/smtp-server-connection.c
@@ -864,7 +864,7 @@ smtp_server_connection_alloc(struct smtp_server *server,
                                p_strarray_dup(pool, set->rcpt_param_extensions);
                }
                if (set->xclient_extensions != NULL) {
-                       server->set.xclient_extensions =
+                       conn->set.xclient_extensions =
                                p_strarray_dup(pool, set->xclient_extensions);
                }