]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: imx: imx7_mipi_csis: Power off the source when stopping streaming
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 10 Mar 2020 16:06:24 +0000 (17:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Apr 2020 14:11:53 +0000 (16:11 +0200)
[ Upstream commit 770cbf89f90b0663499dbb3f03aa81b3322757ec ]

The .s_stream() implementation incorrectly powers on the source when
stopping the stream. Power it off instead.

Fixes: 7807063b862b ("media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/media/imx/imx7-mipi-csis.c

index 99166afca071bc6b9fa35d66c13c5364470391c2..aa1749b1e28fc5176d3dc81672499438eefc28be 100644 (file)
@@ -579,7 +579,7 @@ static int mipi_csis_s_stream(struct v4l2_subdev *mipi_sd, int enable)
                state->flags |= ST_STREAMING;
        } else {
                v4l2_subdev_call(state->src_sd, video, s_stream, 0);
-               ret = v4l2_subdev_call(state->src_sd, core, s_power, 1);
+               ret = v4l2_subdev_call(state->src_sd, core, s_power, 0);
                mipi_csis_stop_stream(state);
                state->flags &= ~ST_STREAMING;
                if (state->debug)