Add test for cpu affinity

Add a test to check BIND 9 honors CPU affinity mask. This requires
some changes to the start script, to construct the named command.

diff --git a/bin/tests/system/Makefile.am b/bin/tests/system/Makefile.am
index 4b61d7a20b62abd3503727d6e7b35a4bda761200..a90f0b62783fabee8725e4dd02ba251f13c7bc13 100644 (file)
--- a/bin/tests/system/Makefile.am
+++ b/bin/tests/system/Makefile.am
@@ -90,6 +90,7 @@ TESTS +=                      \
        checkconf               \
        checknames              \
        checkzone               \
+       cpu                     \
        database                \
        dlz                     \
        dlzexternal             \

diff --git a/bin/tests/system/cpu/clean.sh b/bin/tests/system/cpu/clean.sh
new file mode 100644 (file)
index 0000000..0a6c10b
--- /dev/null
+++ b/bin/tests/system/cpu/clean.sh
@@ -0,0 +1,15 @@
+#!/bin/sh
+#
+# Copyright (C) Internet Systems Consortium, Inc. ("ISC")
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, you can obtain one at https://mozilla.org/MPL/2.0/.
+#
+# See the COPYRIGHT file distributed with this work for additional
+# information regarding copyright ownership.
+
+set -e
+
+rm -f ps.out
+rm -f ns1/named.conf ns1/managed-keys.* ns1/named.run ns1/named.memstats

diff --git a/bin/tests/system/cpu/ns1/named.conf.in b/bin/tests/system/cpu/ns1/named.conf.in
new file mode 100644 (file)
index 0000000..d152b27
--- /dev/null
+++ b/bin/tests/system/cpu/ns1/named.conf.in
@@ -0,0 +1,18 @@
+/*
+ * Copyright (C) Internet Systems Consortium, Inc. ("ISC")
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * See the COPYRIGHT file distributed with this work for additional
+ * information regarding copyright ownership.
+ */
+
+options {
+       query-source address 10.53.0.1;
+       port @PORT@;
+       pid-file "named.pid";
+       listen-on { 10.53.0.1; };
+       listen-on-v6 { none; };
+};

diff --git a/bin/tests/system/cpu/prereq.sh b/bin/tests/system/cpu/prereq.sh
new file mode 100644 (file)
index 0000000..8b0cd6e
--- /dev/null
+++ b/bin/tests/system/cpu/prereq.sh
@@ -0,0 +1,30 @@
+#!/bin/sh -e
+#
+# Copyright (C) Internet Systems Consortium, Inc. ("ISC")
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, you can obtain one at https://mozilla.org/MPL/2.0/.
+#
+# See the COPYRIGHT file distributed with this work for additional
+# information regarding copyright ownership.
+
+set -e
+
+# shellcheck source=conf.sh
+. ../conf.sh
+
+case $(uname) in
+       Linux*)
+               ;;
+       *)
+               echo_i "cpu test only runs on Linux, skipping test"
+               exit 255
+               ;;
+esac
+
+# TASKSET will be an empty string if no taskset program was found.
+TASKSET=$(command -v "taskset" || true)
+if ! test -x "$TASKSET" ; then
+       exit 255
+fi

diff --git a/bin/tests/system/cpu/setup.sh b/bin/tests/system/cpu/setup.sh
new file mode 100644 (file)
index 0000000..5d42868
--- /dev/null
+++ b/bin/tests/system/cpu/setup.sh
@@ -0,0 +1,19 @@
+#!/bin/sh -e
+#
+# Copyright (C) Internet Systems Consortium, Inc. ("ISC")
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, you can obtain one at https://mozilla.org/MPL/2.0/.
+#
+# See the COPYRIGHT file distributed with this work for additional
+# information regarding copyright ownership.
+
+# shellcheck source=conf.sh
+. ../conf.sh
+
+set -e
+
+$SHELL clean.sh
+
+copy_setports ns1/named.conf.in ns1/named.conf

diff --git a/bin/tests/system/cpu/tests.sh b/bin/tests/system/cpu/tests.sh
new file mode 100644 (file)
index 0000000..54cdb0a
--- /dev/null
+++ b/bin/tests/system/cpu/tests.sh
@@ -0,0 +1,46 @@
+#!/bin/sh
+#
+# Copyright (C) Internet Systems Consortium, Inc. ("ISC")
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, you can obtain one at https://mozilla.org/MPL/2.0/.
+#
+# See the COPYRIGHT file distributed with this work for additional
+# information regarding copyright ownership.
+
+# shellcheck source=conf.sh
+. ../conf.sh
+
+status=0
+n=0
+
+n=$((n+1))
+echo_i "stop server ($n)"
+ret=0
+$PERL ../stop.pl cpu ns1 || ret=1
+test "$ret" -eq 0 || echo_i "failed"
+status=$((status+ret))
+
+n=$((n+1))
+echo_i "start server with taskset ($n)"
+ret=0
+start_server --noclean --taskset fff0 --restart --port "${PORT}" cpu ns1 || ret=1
+test "$ret" -eq 0 || echo_i "failed"
+status=$((status+ret))
+
+n=$((n+1))
+echo_i "check ps output ($n)"
+ret=0
+ps -T -o pid,psr,time,comm -e > ps.out
+pid=$(cat ns1/named.pid)
+echo_i "pid=$pid"
+psr=$(awk -v pid="$pid" '$1 == pid && $4 == "isc-net-0000" {print $2}' < ps.out)
+echo_i "psr=$psr"
+# The next available cpu relative to the existing affinity mask is 4.
+test "$psr" -eq 4 || ret=1
+test "$ret" -eq 0 || echo_i "failed"
+status=$((status+ret))
+
+echo_i "exit status: $status"
+[ $status -eq 0 ] || exit 1

diff --git a/bin/tests/system/start.pl b/bin/tests/system/start.pl
index af64569e7ca5e97f26cbe8c450387208593e59a5..54d345069fdbf48876d2a3e40611aa0334a58d00 100755 (executable)
--- a/bin/tests/system/start.pl
+++ b/bin/tests/system/start.pl
@@ -23,7 +23,7 @@ use Getopt::Long;
 use Time::HiRes 'sleep'; # allows sleeping fractional seconds
 
 # Usage:
-#   perl start.pl [--noclean] [--restart] [--port port] test [server [options]]
+#   perl start.pl [--noclean] [--restart] [--port port] [--taskset cpus] test [server [options]]
 #
 #   --noclean       Do not cleanup files in server directory.
 #
@@ -38,6 +38,10 @@ use Time::HiRes 'sleep'; # allows sleeping fractional seconds
 #                   of the file "named.port" in the server directory containing
 #                   the number of the query port.)
 #
+#   --taskset cpus  Use taskset to signal which cpus can be used. For example
+#                   cpus=fff0 means all cpus aexcept for 0, 1, 2, and 3 are
+#                   eligible.
+#
 #   test            Name of the test directory.
 #
 #   server          Name of the server directory.  This will be of the form
@@ -57,15 +61,17 @@ use Time::HiRes 'sleep'; # allows sleeping fractional seconds
 #                   the file is ignored). If "options" is already set, then
 #                   "named.args" is ignored.
 
-my $usage = "usage: $0 [--noclean] [--restart] [--port <port>] test-directory [server-directory [server-options]]";
+my $usage = "usage: $0 [--noclean] [--restart] [--port <port>] [--taskset <cpus>] test-directory [server-directory [server-options]]";
 my $clean = 1;
 my $restart = 0;
 my $queryport = 5300;
+my $taskset = "";
 
 GetOptions(
-       'clean!'   => \$clean,
-       'restart!' => \$restart,
-       'port=i'   => \$queryport,
+       'clean!'    => \$clean,
+       'restart!'  => \$restart,
+       'port=i'    => \$queryport,
+       'taskset=s' => \$taskset,
 ) or die "$usage\n";
 
 my( $test, $server_arg, $options_arg ) = @ARGV;
@@ -232,7 +238,11 @@ sub construct_ns_command {
 
                $command .= "$NAMED -m none -M external ";
        } else {
-               $command = "$NAMED ";
+               if ($taskset) {
+                       $command = "taskset $taskset $NAMED ";
+               } else {
+                       $command = "$NAMED ";
+               }
        }
 
        my $args_file = $testdir . "/" . $server . "/" . "named.args";

diff --git a/util/copyrights b/util/copyrights
index 6d21735927a2ab3c1c4269a7e1d9ac410405b975..a7055d0da9e4c183878f109cc52e549d4677460b 100644 (file)
--- a/util/copyrights
+++ b/util/copyrights
@@ -290,6 +290,10 @@
 ./bin/tests/system/cookie/clean.sh             SH      2014,2015,2016,2018,2019,2020
 ./bin/tests/system/cookie/setup.sh             SH      2018,2019,2020
 ./bin/tests/system/cookie/tests.sh             SH      2014,2015,2016,2017,2018,2019,2020
+./bin/tests/system/cpu/clean.sh                        SH      2020
+./bin/tests/system/cpu/prereq.sh               SH      2020
+./bin/tests/system/cpu/setup.sh                        SH      2020
+./bin/tests/system/cpu/tests.sh                        SH      2020
 ./bin/tests/system/custom-test-driver          X       2020
 ./bin/tests/system/database/clean.sh           SH      2011,2012,2014,2016,2018,2019,2020
 ./bin/tests/system/database/setup.sh           SH      2011,2012,2016,2018,2019,2020