pknock: peer can never be NULL in the hash iterator

Given that pos is non-NULL, list_entry won't make it NULL.

diff --git a/extensions/xt_pknock.c b/extensions/xt_pknock.c
index 7e50162309eb3bdcffb69915e03cec011334e26e..8d466ade46118252627750eea01fe7909042388a 100644 (file)
--- a/extensions/xt_pknock.c
+++ b/extensions/xt_pknock.c
@@ -509,12 +509,9 @@ remove_rule(struct xt_pknock_mtinfo *info)
 
        hashtable_for_each_safe(pos, n, rule->peer_head, peer_hashsize, i) {
                peer = list_entry(pos, struct peer, head);
-
-               if (peer != NULL) {
-                       pk_debug("DELETED", peer);
-                       list_del(pos);
-                       kfree(peer);
-               }
+               pk_debug("DELETED", peer);
+               list_del(pos);
+               kfree(peer);
        }
 
        if (rule->status_proc != NULL)