]> git.ipfire.org Git - thirdparty/ipxe.git/commitdiff
[efi] Allow compiling elf2efi with clang
authorMichael Brown <mcb30@ipxe.org>
Tue, 5 Dec 2023 15:49:17 +0000 (15:49 +0000)
committerMichael Brown <mcb30@ipxe.org>
Tue, 5 Dec 2023 15:49:17 +0000 (15:49 +0000)
The clang compiler does not (and apparently will not ever) allow for
variable-length arrays within structs.

Work around this limitation by using a fixed-length array to hold the
PDB filename in the debug section.

This mirrors wimboot commit f52c3ff ("[efi] Allow compiling elf2efi
with clang").

Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/util/elf2efi.c

index a3aff8f188cc239790dbafac54966f91a46fa104..acde75c08902b497389ab51a4ef7a681aa4e1bdb 100644 (file)
@@ -961,7 +961,7 @@ create_debug_section ( struct pe_header *pe_header, const char *filename ) {
        struct {
                EFI_IMAGE_DEBUG_DIRECTORY_ENTRY debug;
                EFI_IMAGE_DEBUG_CODEVIEW_RSDS_ENTRY rsds;
-               char name[ strlen ( filename ) + 1 ];
+               char name[32];
        } *contents;
 
        /* Allocate PE section */