]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
RDMA/ocrdma: Fix permissions for OCRDMA_RESET_STATS
authorAnton Vasilyev <vasilyev@ispras.ru>
Tue, 8 Aug 2017 15:56:37 +0000 (18:56 +0300)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:33:52 +0000 (21:33 -0400)
[ Upstream commit 744820869166c8c78be891240cf5f66e8a333694 ]

Debugfs file reset_stats is created with S_IRUSR permissions,
but ocrdma_dbgfs_ops_read() doesn't support OCRDMA_RESET_STATS,
whereas ocrdma_dbgfs_ops_write() supports only OCRDMA_RESET_STATS.

The patch fixes misstype with permissions.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Acked-by: Selvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/infiniband/hw/ocrdma/ocrdma_stats.c

index 48d7ef51aa0c209678e0ed4bbe97bc5ff9a881d5..9b8a2c0002809e168379c28ac1d4adf003578efd 100644 (file)
@@ -819,7 +819,7 @@ void ocrdma_add_port_stats(struct ocrdma_dev *dev)
 
        dev->reset_stats.type = OCRDMA_RESET_STATS;
        dev->reset_stats.dev = dev;
-       if (!debugfs_create_file("reset_stats", S_IRUSR, dev->dir,
+       if (!debugfs_create_file("reset_stats", 0200, dev->dir,
                                &dev->reset_stats, &ocrdma_dbg_ops))
                goto err;