]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
utils: Always specify family for address in get_addr_1()
authorSerhey Popovych <serhe.popovych@gmail.com>
Thu, 18 Jan 2018 18:13:42 +0000 (20:13 +0200)
committerDavid Ahern <dsahern@gmail.com>
Sun, 21 Jan 2018 17:38:17 +0000 (09:38 -0800)
Set ->family correctly when string representing address
is "default", "all" or "any": get_addr_1() might be called
with AF_UNSPEC (e.g. get_addr() -> get_addr_1()).

Extend support for zero address to all address families,
not only AF_INET and AF_INET6 when one explicitly given
as @family: use af_byte_len() to correctly set address length.

Still assume AF_INET when @family is AF_UNSPEC.

Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
lib/utils.c

index 9fa522047fdcabbf3166b16bf4053534c228deb4..a023e747d3841b423bd2d9454e114792814d007f 100644 (file)
@@ -543,8 +543,8 @@ int get_addr_1(inet_prefix *addr, const char *name, int family)
            strcmp(name, "any") == 0) {
                if ((family == AF_DECnet) || (family == AF_MPLS))
                        return -1;
-               addr->family = family;
-               addr->bytelen = (family == AF_INET6 ? 16 : 4);
+               addr->family = (family != AF_UNSPEC) ? family : AF_INET;
+               addr->bytelen = af_byte_len(addr->family);
                addr->bitlen = -1;
                return 0;
        }