]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
winbind: Save an intermediate NULL check with talloc_asprintf_addbuf()
authorVolker Lendecke <vl@samba.org>
Wed, 30 Nov 2022 13:23:26 +0000 (14:23 +0100)
committerJeremy Allison <jra@samba.org>
Wed, 14 Dec 2022 04:32:34 +0000 (04:32 +0000)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/winbindd/winbindd_wins_byname.c

index 2014714ff0122024cd6075f12f73470a5c498997..ae170b2e0b9e50abf4a34e25ed100d97f05e3905 100644 (file)
@@ -133,16 +133,13 @@ NTSTATUS winbindd_wins_byname_recv(struct tevent_req *req,
                char addr[INET6_ADDRSTRLEN];
                print_sockaddr(addr, sizeof(addr), &state->addrs[i]);
                D_NOTICE("%zu: %s\n", i, addr);
-               response = talloc_asprintf_append_buffer(
-                       response, "%s%s", addr,
+               talloc_asprintf_addbuf(
+                       &response, "%s%s", addr,
                        i < (state->num_addrs-1) ? " " : "");
-               if (response == NULL) {
-                       return NT_STATUS_NO_MEMORY;
-               }
        }
 
-       response = talloc_asprintf_append_buffer(
-               response, "\t%s\n", state->request->data.winsreq);
+       talloc_asprintf_addbuf(
+               &response, "\t%s\n", state->request->data.winsreq);
        if (response == NULL) {
                return NT_STATUS_NO_MEMORY;
        }