powerpc/audit: Convert powerpc to AUDIT_ARCH_COMPAT_GENERIC

Commit e65e1fc2d24b ("[PATCH] syscall class hookup for all normal
targets") added generic support for AUDIT but that didn't include
support for bi-arch like powerpc.

Commit 4b58841149dc ("audit: Add generic compat syscall support")
added generic support for bi-arch.

Convert powerpc to that bi-arch generic audit support.

With this change generated text is similar.

Thomas has confirmed that the previously failing filter_exclude/test
is now successful both without and with this patch, see [1]

[1] https://lore.kernel.org/all/20260306115350-ef265661-6d6b-4043-9bd0-8e6b437d0d67@linutronix.de/

Link: https://github.com/linuxppc/issues/issues/412
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/261b1be5b8dc526b83d73e8281e682a73536ea28.1773155031.git.chleroy@kernel.org

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index fd3e66e4ee0a1c92e2551d735bff953cce2c9d17..60b9862d530e7566113409a5e43ffb3783530af7 100644 (file)
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -189,6 +189,7 @@ config PPC
        select ARCH_WANT_OPTIMIZE_DAX_VMEMMAP   if PPC_RADIX_MMU
        select ARCH_WANTS_MODULES_DATA_IN_VMALLOC       if PPC_BOOK3S_32 || PPC_8xx
        select ARCH_WEAK_RELEASE_ACQUIRE
+       select AUDIT_ARCH_COMPAT_GENERIC
        select BINFMT_ELF
        select BUILDTIME_TABLE_SORT
        select CLONE_BACKWARDS
@@ -371,10 +372,6 @@ config GENERIC_TBSYNC
        bool
        default y if PPC32 && SMP
 
-config AUDIT_ARCH
-       bool
-       default y
-
 config GENERIC_BUG
        bool
        default y

diff --git a/arch/powerpc/include/asm/unistd32.h b/arch/powerpc/include/asm/unistd32.h
new file mode 100644 (file)
index 0000000..0768989
--- /dev/null
+++ b/arch/powerpc/include/asm/unistd32.h
@@ -0,0 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+#ifndef _ASM_POWERPC_UNISTD32_H_
+#define _ASM_POWERPC_UNISTD32_H_
+
+#include <asm/unistd_32.h>
+
+#endif /* _ASM_POWERPC_UNISTD32_H_ */

diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
index 2f0a2e69c607bc42a8ff04492874f9b103e8e33e..7bf6b16b2d93c4bd08e3c9ec422684c9e7e7a3f8 100644 (file)
--- a/arch/powerpc/kernel/Makefile
+++ b/arch/powerpc/kernel/Makefile
@@ -149,9 +149,6 @@ obj-$(CONFIG_PCI)           += pci_$(BITS).o $(pci64-y) \
                                   pci-common.o pci_of_scan.o
 obj-$(CONFIG_PCI_MSI)          += msi.o
 
-obj-$(CONFIG_AUDIT)            += audit.o
-obj64-$(CONFIG_AUDIT)          += compat_audit.o
-
 obj-y                          += trace/
 
 ifneq ($(CONFIG_PPC_INDIRECT_PIO),y)

diff --git a/arch/powerpc/kernel/audit.c b/arch/powerpc/kernel/audit.c
deleted file mode 100644 (file)
index 92298d6..0000000
--- a/arch/powerpc/kernel/audit.c
+++ /dev/null
@@ -1,87 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-#include <linux/init.h>
-#include <linux/types.h>
-#include <linux/audit.h>
-#include <asm/unistd.h>
-
-#include "audit_32.h"
-
-static unsigned dir_class[] = {
-#include <asm-generic/audit_dir_write.h>
-~0U
-};
-
-static unsigned read_class[] = {
-#include <asm-generic/audit_read.h>
-~0U
-};
-
-static unsigned write_class[] = {
-#include <asm-generic/audit_write.h>
-~0U
-};
-
-static unsigned chattr_class[] = {
-#include <asm-generic/audit_change_attr.h>
-~0U
-};
-
-static unsigned signal_class[] = {
-#include <asm-generic/audit_signal.h>
-~0U
-};
-
-int audit_classify_arch(int arch)
-{
-#ifdef CONFIG_PPC64
-       if (arch == AUDIT_ARCH_PPC)
-               return 1;
-#endif
-       return 0;
-}
-
-int audit_classify_syscall(int abi, unsigned syscall)
-{
-#ifdef CONFIG_PPC64
-       if (abi == AUDIT_ARCH_PPC)
-               return ppc32_classify_syscall(syscall);
-#endif
-       switch(syscall) {
-       case __NR_open:
-               return AUDITSC_OPEN;
-       case __NR_openat:
-               return AUDITSC_OPENAT;
-       case __NR_socketcall:
-               return AUDITSC_SOCKETCALL;
-       case __NR_execve:
-               return AUDITSC_EXECVE;
-       case __NR_openat2:
-               return AUDITSC_OPENAT2;
-       default:
-               return AUDITSC_NATIVE;
-       }
-}
-
-static int __init audit_classes_init(void)
-{
-#ifdef CONFIG_PPC64
-       extern __u32 ppc32_dir_class[];
-       extern __u32 ppc32_write_class[];
-       extern __u32 ppc32_read_class[];
-       extern __u32 ppc32_chattr_class[];
-       extern __u32 ppc32_signal_class[];
-       audit_register_class(AUDIT_CLASS_WRITE_32, ppc32_write_class);
-       audit_register_class(AUDIT_CLASS_READ_32, ppc32_read_class);
-       audit_register_class(AUDIT_CLASS_DIR_WRITE_32, ppc32_dir_class);
-       audit_register_class(AUDIT_CLASS_CHATTR_32, ppc32_chattr_class);
-       audit_register_class(AUDIT_CLASS_SIGNAL_32, ppc32_signal_class);
-#endif
-       audit_register_class(AUDIT_CLASS_WRITE, write_class);
-       audit_register_class(AUDIT_CLASS_READ, read_class);
-       audit_register_class(AUDIT_CLASS_DIR_WRITE, dir_class);
-       audit_register_class(AUDIT_CLASS_CHATTR, chattr_class);
-       audit_register_class(AUDIT_CLASS_SIGNAL, signal_class);
-       return 0;
-}
-
-__initcall(audit_classes_init);

diff --git a/arch/powerpc/kernel/compat_audit.c b/arch/powerpc/kernel/compat_audit.c
deleted file mode 100644 (file)
index 57b38c5..0000000
--- a/arch/powerpc/kernel/compat_audit.c
+++ /dev/null
@@ -1,49 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-#undef __powerpc64__
-#include <linux/audit_arch.h>
-#include <asm/unistd.h>
-
-#include "audit_32.h"
-
-unsigned ppc32_dir_class[] = {
-#include <asm-generic/audit_dir_write.h>
-~0U
-};
-
-unsigned ppc32_chattr_class[] = {
-#include <asm-generic/audit_change_attr.h>
-~0U
-};
-
-unsigned ppc32_write_class[] = {
-#include <asm-generic/audit_write.h>
-~0U
-};
-
-unsigned ppc32_read_class[] = {
-#include <asm-generic/audit_read.h>
-~0U
-};
-
-unsigned ppc32_signal_class[] = {
-#include <asm-generic/audit_signal.h>
-~0U
-};
-
-int ppc32_classify_syscall(unsigned syscall)
-{
-       switch(syscall) {
-       case __NR_open:
-               return AUDITSC_OPEN;
-       case __NR_openat:
-               return AUDITSC_OPENAT;
-       case __NR_socketcall:
-               return AUDITSC_SOCKETCALL;
-       case __NR_execve:
-               return AUDITSC_EXECVE;
-       case __NR_openat2:
-               return AUDITSC_OPENAT2;
-       default:
-               return AUDITSC_COMPAT;
-       }
-}