]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: rockchip: Fix pinctrl node names for RK3528
authorJonas Karlman <jonas@kwiboo.se>
Sat, 21 Jun 2025 11:38:57 +0000 (11:38 +0000)
committerHeiko Stuebner <heiko@sntech.de>
Fri, 11 Jul 2025 13:25:41 +0000 (15:25 +0200)
Following warnings can be observed with CHECK_DTBS=y for the RK3528:

  rk3528-pinctrl.dtsi:101.36-105.5: Warning (node_name_chars_strict):
    /pinctrl/fephy/fephym0-led_dpx: Character '_' not recommended in node name
  rk3528-pinctrl.dtsi:108.38-112.5: Warning (node_name_chars_strict):
    /pinctrl/fephy/fephym0-led_link: Character '_' not recommended in node name
  rk3528-pinctrl.dtsi:115.36-119.5: Warning (node_name_chars_strict):
    /pinctrl/fephy/fephym0-led_spd: Character '_' not recommended in node name
  rk3528-pinctrl.dtsi:122.36-126.5: Warning (node_name_chars_strict):
   /pinctrl/fephy/fephym1-led_dpx: Character '_' not recommended in node name
  rk3528-pinctrl.dtsi:129.38-133.5: Warning (node_name_chars_strict):
    /pinctrl/fephy/fephym1-led_link: Character '_' not recommended in node name
  rk3528-pinctrl.dtsi:136.36-140.5: Warning (node_name_chars_strict):
    /pinctrl/fephy/fephym1-led_spd: Character '_' not recommended in node name
  rk3528-pinctrl.dtsi:782.32-790.5: Warning (node_name_chars_strict):
    /pinctrl/rgmii/rgmii-rx_bus2: Character '_' not recommended in node name
  rk3528-pinctrl.dtsi:793.32-801.5: Warning (node_name_chars_strict):
    /pinctrl/rgmii/rgmii-tx_bus2: Character '_' not recommended in node name
  rk3528-pinctrl.dtsi:804.36-810.5: Warning (node_name_chars_strict):
    /pinctrl/rgmii/rgmii-rgmii_clk: Character '_' not recommended in node name
  rk3528-pinctrl.dtsi:813.36-823.5: Warning (node_name_chars_strict):
    /pinctrl/rgmii/rgmii-rgmii_bus: Character '_' not recommended in node name

Rename the affected nodes to fix these warnings.

Fixes: a31fad19ae39 ("arm64: dts: rockchip: Add pinctrl and gpio nodes for RK3528")
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Link: https://lore.kernel.org/r/20250621113859.2146400-1-jonas@kwiboo.se
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3528-pinctrl.dtsi

index ea051362fb265148a9288a56ced7b21c64ba6fbc..59b75c91bbb7f0854bfd68d110e3e6a05acb7c53 100644 (file)
 
        fephy {
                /omit-if-no-ref/
-               fephym0_led_dpx: fephym0-led_dpx {
+               fephym0_led_dpx: fephym0-led-dpx {
                        rockchip,pins =
                                /* fephy_led_dpx_m0 */
                                <4 RK_PB5 2 &pcfg_pull_none>;
                };
 
                /omit-if-no-ref/
-               fephym0_led_link: fephym0-led_link {
+               fephym0_led_link: fephym0-led-link {
                        rockchip,pins =
                                /* fephy_led_link_m0 */
                                <4 RK_PC0 2 &pcfg_pull_none>;
                };
 
                /omit-if-no-ref/
-               fephym0_led_spd: fephym0-led_spd {
+               fephym0_led_spd: fephym0-led-spd {
                        rockchip,pins =
                                /* fephy_led_spd_m0 */
                                <4 RK_PB7 2 &pcfg_pull_none>;
                };
 
                /omit-if-no-ref/
-               fephym1_led_dpx: fephym1-led_dpx {
+               fephym1_led_dpx: fephym1-led-dpx {
                        rockchip,pins =
                                /* fephy_led_dpx_m1 */
                                <2 RK_PA4 5 &pcfg_pull_none>;
                };
 
                /omit-if-no-ref/
-               fephym1_led_link: fephym1-led_link {
+               fephym1_led_link: fephym1-led-link {
                        rockchip,pins =
                                /* fephy_led_link_m1 */
                                <2 RK_PA6 5 &pcfg_pull_none>;
                };
 
                /omit-if-no-ref/
-               fephym1_led_spd: fephym1-led_spd {
+               fephym1_led_spd: fephym1-led-spd {
                        rockchip,pins =
                                /* fephy_led_spd_m1 */
                                <2 RK_PA5 5 &pcfg_pull_none>;
                };
 
                /omit-if-no-ref/
-               rgmii_rx_bus2: rgmii-rx_bus2 {
+               rgmii_rx_bus2: rgmii-rx-bus2 {
                        rockchip,pins =
                                /* rgmii_rxd0 */
                                <3 RK_PA3 2 &pcfg_pull_none>,
                };
 
                /omit-if-no-ref/
-               rgmii_tx_bus2: rgmii-tx_bus2 {
+               rgmii_tx_bus2: rgmii-tx-bus2 {
                        rockchip,pins =
                                /* rgmii_txd0 */
                                <3 RK_PA1 2 &pcfg_pull_none_drv_level_2>,
                };
 
                /omit-if-no-ref/
-               rgmii_rgmii_clk: rgmii-rgmii_clk {
+               rgmii_rgmii_clk: rgmii-rgmii-clk {
                        rockchip,pins =
                                /* rgmii_rxclk */
                                <3 RK_PA5 2 &pcfg_pull_none>,
                };
 
                /omit-if-no-ref/
-               rgmii_rgmii_bus: rgmii-rgmii_bus {
+               rgmii_rgmii_bus: rgmii-rgmii-bus {
                        rockchip,pins =
                                /* rgmii_rxd2 */
                                <3 RK_PA7 2 &pcfg_pull_none>,