]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
output-json: fix Coverity USE_AFTER_FREE
authorJason Ish <jason.ish@oisf.net>
Tue, 11 Aug 2020 15:30:01 +0000 (09:30 -0600)
committerVictor Julien <victor@inliniac.net>
Mon, 24 Aug 2020 07:16:27 +0000 (09:16 +0200)
Return error if plugin open fails. Fixes Coverity CID 1465664
USE_AFTER_FREE error.

Redmine issue:
https://redmine.openinfosecfoundation.org/issues/3864

src/output-json.c

index 83538777559dafd4c5842e458b959145b5554eff..7e55ba0385a541fdddd9ad5130dcb186c5766b9a 100644 (file)
@@ -1198,6 +1198,7 @@ OutputInitResult OutputJsonInitCtx(ConfNode *conf)
                 LogFileFreeCtx(json_ctx->file_ctx);
                 SCFree(json_ctx);
                 SCFree(output_ctx);
+                return result;
             } else {
                 json_ctx->file_ctx->plugin = json_ctx->plugin;
                 json_ctx->file_ctx->plugin_data = plugin_data;