ast_copy_string(tc->exten, chan->exten, sizeof(tc->exten));
ast_channel_unlock(tc);
+ ast_channel_unlock(chan);
res = ast_call(tc, numsubst, 0); /* Place the call, but don't wait on the answer */
+ ast_channel_lock(chan);
/* Save the info in cdr's that we called them */
if (chan->cdr)
}
/* Allocate channel used for chanvar substitution */
ast = ast_dummy_channel_alloc();
+ if (!ast) {
+ return -1;
+ }
snprintf(dur, sizeof(dur), "%d:%02d", duration / 60, duration % 60);
ast_safe_system(tmp2);
ast_debug(1, "Sent message to %s with command '%s' - %s\n", vmu->email, global_mailcmd, template->attachment ? "(media attachment)" : "");
ast_debug(3, "Actual command used: %s\n", tmp2);
- if (ast)
- ast = ast_channel_release(ast);
+ ast = ast_channel_unref(ast);
ast_free(str1);
ast_free(str2);
return 0;
} else {
fprintf(p, "From: %s <%s>" ENDL, ast_str_quote(&str2, 0, ast_str_buffer(str1)), who);
}
- ast = ast_channel_release(ast);
+ ast = ast_channel_unref(ast);
} else {
ast_log(AST_LOG_WARNING, "Cannot allocate the channel for variables substitution\n");
}
} else {
fprintf(p, "Subject: %s" ENDL, ast_str_buffer(str1));
}
- ast = ast_channel_release(ast);
+ ast = ast_channel_unref(ast);
} else {
ast_log(AST_LOG_WARNING, "Cannot allocate the channel for variables substitution\n");
}
#else
fprintf(p, "%s" ENDL, ast_str_buffer(str1));
#endif
- ast = ast_channel_release(ast);
+ ast = ast_channel_unref(ast);
} else {
ast_log(AST_LOG_WARNING, "Cannot allocate the channel for variables substitution\n");
}
} else {
fprintf(p, "From: %s <%s>" ENDL, ast_str_quote(&str2, 0, ast_str_buffer(str1)), who);
}
- ast = ast_channel_release(ast);
+ ast = ast_channel_unref(ast);
} else {
ast_log(AST_LOG_WARNING, "Cannot allocate the channel for variables substitution\n");
}
} else {
fprintf(p, "Subject: %s" ENDL, ast_str_buffer(str1));
}
- ast = ast_channel_release(ast);
+ ast = ast_channel_unref(ast);
} else {
ast_log(AST_LOG_WARNING, "Cannot allocate the channel for variables substitution\n");
}
prep_email_sub_vars(ast, vmu, msgnum + 1, context, mailbox, fromfolder, cidnum, cidname, dur, date, category, flag);
ast_str_substitute_variables(&str1, 0, ast, pagerbody);
fprintf(p, "%s" ENDL, ast_str_buffer(str1));
- ast = ast_channel_release(ast);
+ ast = ast_channel_unref(ast);
} else {
ast_log(AST_LOG_WARNING, "Cannot allocate the channel for variables substitution\n");
}
!(vmu = find_or_create(testcontext, testmailbox))) {
ast_test_status_update(test, "Cannot create vmu structure\n");
ast_unreplace_sigchld();
+#ifdef IMAP_STORAGE
+ chan = ast_channel_unref(chan);
+#endif
return AST_TEST_FAIL;
}
ast_test_status_update(test, "Unable to create test voicemail: %s\n",
syserr > 0 ? strerror(syserr) : "unable to fork()");
ast_unreplace_sigchld();
+#ifdef IMAP_STORAGE
+ chan = ast_channel_unref(chan);
+#endif
return AST_TEST_FAIL;
}
}
}
#ifdef IMAP_STORAGE
- chan = ast_channel_release(chan);
+ chan = ast_channel_unref(chan);
#endif
/* And remove test directory */
}
dummy = ast_dummy_channel_alloc();
-
if (!dummy) {
ast_log(LOG_ERROR, "Unable to allocate channel for variable subsitution.\n");
return -1;
AST_RWLIST_UNLOCK(&sinks);
- ast_channel_release(dummy);
+ ast_channel_unref(dummy);
return 0;
}
}
dummy->cdr = ast_cdr_dup(cdr);
pbx_substitute_variables_helper(dummy, ast_str_buffer(customfields), buf, sizeof(buf) - 1);
- ast_channel_release(dummy);
+ ast_channel_unref(dummy);
}
ast_rwlock_unlock(&customfields_lock);
}
sql = sqlite3_mprintf("INSERT INTO %q (%s) VALUES (%s)", table, columns, ast_str_buffer(value_string));
ast_debug(1, "About to log: %s\n", sql);
- ast_channel_release(dummy);
+ ast_channel_unref(dummy);
ast_free(value_string);
}
AST_RWLIST_UNLOCK(&sinks);
- ast_channel_release(dummy);
+ ast_channel_unref(dummy);
return 0;
}
}
dummy = ast_cel_fabricate_channel_from_event(event);
-
if (!dummy) {
ast_log(LOG_ERROR, "Unable to fabricate channel from CEL event.\n");
return;
AST_RWLIST_UNLOCK(&sinks);
- ast_channel_release(dummy);
+ ast_channel_unref(dummy);
}
static int unload_module(void)
}
sql = sqlite3_mprintf("INSERT INTO %q (%s) VALUES (%s)", table, columns, ast_str_buffer(value_string));
ast_debug(1, "About to log: %s\n", sql);
- dummy = ast_channel_release(dummy);
+ dummy = ast_channel_unref(dummy);
ast_free(value_string);
}
ast_autoservice_stop(chan);
pbx_builtin_setvar_helper(chan, "ODBCSTATUS", status);
} else {
- ast_channel_release(chan);
+ ast_channel_unref(chan);
}
return -1;
}
ast_str_substitute_variables(&insertbuf, 0, chan, query->sql_insert);
if (bogus_chan) {
- chan = ast_channel_release(chan);
+ chan = ast_channel_unref(chan);
} else {
/* Restore prior values */
for (i = 0; i < args.argc; i++) {
ast_str_substitute_variables(&sql, 0, chan, query->sql_read);
if (bogus_chan) {
- chan = ast_channel_release(chan);
+ chan = ast_channel_unref(chan);
} else {
/* Restore prior values */
for (x = 0; x < args.argc; x++) {
SQLFreeHandle(SQL_HANDLE_STMT, stmt);
ast_odbc_release_obj(obj);
obj = NULL;
- pbx_builtin_setvar_helper(chan, "ODBCSTATUS", "MEMERROR");
- if (chan)
+ if (!bogus_chan) {
+ pbx_builtin_setvar_helper(chan, "ODBCSTATUS", "MEMERROR");
ast_autoservice_stop(chan);
- if (bogus_chan) {
- ast_channel_release(chan);
}
return -1;
}
SQLFreeHandle(SQL_HANDLE_STMT, stmt);
ast_odbc_release_obj(obj);
obj = NULL;
- pbx_builtin_setvar_helper(chan, "ODBCROWS", rowcount);
- pbx_builtin_setvar_helper(chan, "ODBCSTATUS", "MEMERROR");
- ast_autoservice_stop(chan);
+ if (!bogus_chan) {
+ pbx_builtin_setvar_helper(chan, "ODBCROWS", rowcount);
+ pbx_builtin_setvar_helper(chan, "ODBCSTATUS", "MEMERROR");
+ ast_autoservice_stop(chan);
+ }
return -1;
}
resultset = tmp;
char_args = ast_strdupa(a->argv[3]);
chan = ast_dummy_channel_alloc();
+ if (!chan) {
+ AST_RWLIST_UNLOCK(&queries);
+ return CLI_FAILURE;
+ }
AST_STANDARD_APP_ARGS(args, char_args);
for (i = 0; i < args.argc; i++) {
}
ast_str_substitute_variables(&sql, 0, chan, query->sql_read);
- chan = ast_channel_release(chan);
+ chan = ast_channel_unref(chan);
if (a->argc == 5 && !strcmp(a->argv[4], "exec")) {
/* Execute the query */
char_values = ast_strdupa(a->argv[4]);
chan = ast_dummy_channel_alloc();
+ if (!chan) {
+ AST_RWLIST_UNLOCK(&queries);
+ return CLI_FAILURE;
+ }
AST_STANDARD_APP_ARGS(args, char_args);
for (i = 0; i < args.argc; i++) {
pbx_builtin_pushvar_helper(chan, "VALUE", S_OR(a->argv[4], ""));
ast_str_substitute_variables(&sql, 0, chan, query->sql_write);
ast_debug(1, "SQL is %s\n", ast_str_buffer(sql));
- chan = ast_channel_release(chan);
+
+ chan = ast_channel_unref(chan);
if (a->argc == 6 && !strcmp(a->argv[5], "exec")) {
/* Execute the query */
/*!
* \brief Create a fake channel from data in a CEL event
*
- * This function creates a fake channel containing the serialized channel data
- * in the given cel event. It must be released with ast_channel_release.
+ * \note
+ * This function creates a fake channel containing the
+ * serialized channel data in the given cel event. It should be
+ * released with ast_channel_unref() but could be released with
+ * ast_channel_release().
*
* \param event the CEL event
*
__ast_channel_alloc(needqueue, state, cid_num, cid_name, acctcode, exten, context, linkedid, amaflag, \
__FILE__, __LINE__, __FUNCTION__, __VA_ARGS__)
+#if defined(REF_DEBUG) || defined(__AST_DEBUG_MALLOC)
/*!
* \brief Create a fake channel structure
*
* \note This function should ONLY be used to create a fake channel
* that can then be populated with data for use in variable
* substitution when a real channel does not exist.
+ *
+ * \note The created dummy channel should be destroyed by
+ * ast_channel_unref(). Using ast_channel_release() needlessly
+ * grabs the channel container lock and can cause a deadlock as
+ * a result. Also grabbing the channel container lock reduces
+ * system performance.
*/
-#if defined(REF_DEBUG) || defined(__AST_DEBUG_MALLOC)
#define ast_dummy_channel_alloc() __ast_dummy_channel_alloc(__FILE__, __LINE__, __PRETTY_FUNCTION__)
struct ast_channel *__ast_dummy_channel_alloc(const char *file, int line, const char *function);
#else
+/*!
+ * \brief Create a fake channel structure
+ *
+ * \retval NULL failure
+ * \retval non-NULL successfully allocated channel
+ *
+ * \note This function should ONLY be used to create a fake channel
+ * that can then be populated with data for use in variable
+ * substitution when a real channel does not exist.
+ *
+ * \note The created dummy channel should be destroyed by
+ * ast_channel_unref(). Using ast_channel_release() needlessly
+ * grabs the channel container lock and can cause a deadlock as
+ * a result. Also grabbing the channel container lock reduces
+ * system performance.
+ */
struct ast_channel *ast_dummy_channel_alloc(void);
#endif
/*!
* \brief Make a call
+ * \note Absolutely _NO_ channel locks should be held before calling this function.
* \param chan which channel to make the call on
* \param addr destination of the call
* \param timeout time to wait on for connect
/* first, get the variables from the event */
if (ast_cel_fill_record(event, &record)) {
- ast_channel_release(tchan);
+ ast_channel_unref(tchan);
return NULL;
}
if (!ast_strlen_zero(exec_after_rotate)) {
struct ast_channel *c = ast_dummy_channel_alloc();
char buf[512];
+
pbx_builtin_setvar_helper(c, "filename", filename);
pbx_substitute_variables_helper(c, exec_after_rotate, buf, sizeof(buf));
+ if (c) {
+ c = ast_channel_unref(c);
+ }
if (ast_safe_system(buf) == -1) {
ast_log(LOG_WARNING, "error executing '%s'\n", buf);
}
- c = ast_channel_release(c);
}
return res;
}
const char *name = astman_get_header(m, "Channel");
const char *varname = astman_get_header(m, "Variable");
char *varval;
- char workspace[1024] = "";
+ char workspace[1024];
if (ast_strlen_zero(varname)) {
astman_send_error(s, m, "No variable specified");
}
}
+ workspace[0] = '\0';
if (varname[strlen(varname) - 1] == ')') {
if (!c) {
c = ast_dummy_channel_alloc();
if (c) {
ast_func_read(c, (char *) varname, workspace, sizeof(workspace));
- c = ast_channel_release(c);
} else
ast_log(LOG_ERROR, "Unable to allocate bogus channel for variable substitution. Function results may be blank.\n");
} else {
cp4 = ast_func_read2(c, finalvars, &substr3, 0) ? NULL : ast_str_buffer(substr3);
/* Don't deallocate the varshead that was passed in */
memcpy(&bogus->varshead, &old, sizeof(bogus->varshead));
- ast_channel_release(bogus);
+ ast_channel_unref(bogus);
} else {
ast_log(LOG_ERROR, "Unable to allocate bogus channel for variable substitution. Function results may be blank.\n");
}
cp4 = ast_func_read(c, vars, workspace, VAR_BUF_SIZE) ? NULL : workspace;
/* Don't deallocate the varshead that was passed in */
memcpy(&c->varshead, &old, sizeof(c->varshead));
- c = ast_channel_release(c);
+ c = ast_channel_unref(c);
} else {
ast_log(LOG_ERROR, "Unable to allocate bogus channel for variable substitution. Function results may be blank.\n");
}
/* If we are adding a hint evalulate in variables and global variables */
if (priority == PRIORITY_HINT && strstr(application, "${") && !strstr(extension, "_")) {
struct ast_channel *c = ast_dummy_channel_alloc();
- ast_copy_string(c->exten, extension, sizeof(c->exten));
- ast_copy_string(c->context, con->name, sizeof(c->context));
+ if (c) {
+ ast_copy_string(c->exten, extension, sizeof(c->exten));
+ ast_copy_string(c->context, con->name, sizeof(c->context));
+ }
pbx_substitute_variables_helper(c, application, expand_buf, sizeof(expand_buf));
application = expand_buf;
- ast_channel_release(c);
+ if (c) {
+ ast_channel_unref(c);
+ }
}
length = sizeof(struct ast_exten);
chan->cdr = ast_cdr_alloc();
if (!chan->cdr) {
/* allocation of the cdr failed */
- chan = ast_channel_release(chan); /* free the channel */
+ chan = ast_channel_unref(chan); /* free the channel */
return -1; /* return failure */
}
ast_cdr_failed(chan->cdr); /* set the status to failed */
ast_cdr_detach(chan->cdr); /* post and free the record */
chan->cdr = NULL;
- chan = ast_channel_release(chan); /* free the channel */
+ chan = ast_channel_unref(chan); /* free the channel */
return 0; /* success */
}
if (!(str = ast_str_create(16))) {
ast_test_status_update(test, "Unable to allocate dynamic string buffer\n");
- ast_channel_release(chan);
+ ast_channel_unref(chan);
return AST_TEST_FAIL;
}
if (!(con = ast_context_find_or_create(NULL, NULL, "tests_test_gosub_virtual_context", "test_gosub"))) {
ast_test_status_update(test, "Unable to create test dialplan context");
ast_free(str);
- ast_channel_release(chan);
+ ast_channel_unref(chan);
return AST_TEST_FAIL;
}
}
ast_free(str);
- ast_channel_release(chan);
+ ast_channel_unref(chan);
ast_context_remove_extension2(con, "s", 1, NULL, 0);
ast_context_destroy(con, "test_gosub");
projects / thirdparty / asterisk.git / commitdiff
