api.c: fix resource leak in cg_chmod_path()

Fix resource leak, reported by Coverity Tool:

CID 276160 (#1 of 1): Resource leak (RESOURCE_LEAK)10. leaked_handle:
Handle variable fd going out of scope leaks the handle.

In cg_chmod_path(), the file descriptor checks for fd > 0, Coverity
warns about the possibility of the file descriptor being 0, fix it by
changing the check from '0' -> '-1'.

Fixes: 91cf2e4b7ceb ("api.c: fix file open in cg_chmod_path()")
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

diff --git a/src/api.c b/src/api.c
index 92e211ddfda7076d71ae307abbd5f7ab902a54f7..d8163e6769de8f298fce4fd3f544f07e78e76b48 100644 (file)
--- a/src/api.c
+++ b/src/api.c
@@ -248,7 +248,7 @@ fail:
        cgroup_warn("cannot change permissions of file %s: %s\n", path, strerror(errno));
        last_errno = errno;
 
-       if (fd > 0)
+       if (fd > -1)
                close(fd);
 
        return ECGOTHER;