counters: simplify and speedup counters sync

diff --git a/src/counters.c b/src/counters.c
index 309a290da1ce4a41ff12e43d9e46dbce5010cc04..27056b6fd33c0522a6482ebd128ddfeb7f102780 100644 (file)
--- a/src/counters.c
+++ b/src/counters.c
@@ -1188,7 +1188,6 @@ int SCPerfSetupPrivate(ThreadVars *tv)
  */
 int SCPerfUpdateCounterArray(SCPerfPrivateContext *pca, SCPerfPublicContext *pctx)
 {
-    SCPerfCounter *pc = NULL;
     SCPCAElem *pcae = NULL;
     uint32_t i = 0;
 
@@ -1200,22 +1199,9 @@ int SCPerfUpdateCounterArray(SCPerfPrivateContext *pca, SCPerfPublicContext *pct
     pcae = pca->head;
 
     SCMutexLock(&pctx->m);
-    pc = pctx->head;
-
     for (i = 1; i <= pca->size; i++) {
-        while (pc != NULL) {
-            if (pc->id != pcae[i].id) {
-                pc = pc->next;
-                continue;
-            }
-
-            SCPerfCopyCounterValue(&pcae[i]);
-
-            pc = pc->next;
-            break;
-        }
+        SCPerfCopyCounterValue(&pcae[i]);
     }
-
     SCMutexUnlock(&pctx->m);
 
     pctx->perf_flag = 0;