]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: utils: smbtree. Ensure we don't call cli_RNetShareEnum() on an SMB1 connection.
authorJeremy Allison <jra@samba.org>
Tue, 29 Oct 2019 19:11:49 +0000 (12:11 -0700)
committerRalph Boehme <slow@samba.org>
Wed, 30 Oct 2019 20:44:31 +0000 (20:44 +0000)
Last unprotected call of cli_RNetShareEnum(). Not a libsmbclient
bug here but might as well fix the last caller as part of the
fix for the bug.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14174

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/utils/smbtree.c

index 0a0dac0f9d5deffb75d05a0eee87facce63002ee..8e4caf0e80ba4c9698bca787352492c9a06564de 100644 (file)
@@ -26,6 +26,7 @@
 #include "libsmb/libsmb.h"
 #include "libsmb/namequery.h"
 #include "libsmb/clirap.h"
+#include "../libcli/smb/smbXcli_base.h"
 
 static int use_bcast;
 
@@ -231,6 +232,10 @@ static bool get_shares(char *server_name, const struct user_auth_info *user_info
        if (get_rpc_shares(cli, add_name, &shares))
                return True;
 
+       if (smbXcli_conn_protocol(cli->conn) > PROTOCOL_NT1) {
+               return false;
+       }
+
         if (!cli_RNetShareEnum(cli, add_name, &shares))
                 return False;