]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
ada: Fix Valid_Scalars attribute applied to types from limited with
authorEric Botcazou <ebotcazou@adacore.com>
Sun, 2 Jul 2023 08:07:55 +0000 (10:07 +0200)
committerMarc Poulhiès <poulhies@adacore.com>
Tue, 18 Jul 2023 13:11:46 +0000 (15:11 +0200)
The attribute is wrongly computed as always True because, unlike for e.g.
private types, Validated_View does not look through the limited view.

gcc/ada/

* sem_util.ads (Validated_View): Document enhanced behavior.
* sem_util.adb (Validated_View): Return the nonlimited view, if any,
of types coming from a limited with.

gcc/ada/sem_util.adb
gcc/ada/sem_util.ads

index 821aacf1ccb5964ff19d74d6f51e951de51bd8f9..222fd72a0614586a081b9ba71a2f92674370e08c 100644 (file)
@@ -29231,6 +29231,13 @@ package body Sem_Util is
             return Typ;
          end if;
 
+      elsif From_Limited_With (Typ) then
+         if Has_Non_Limited_View (Typ) then
+            return Validated_View (Non_Limited_View (Typ));
+         else
+            return Typ;
+         end if;
+
       else
          return Typ;
       end if;
index 3751fb737027f196f35f9ed792206b471cf3dd83..7fc77de2b8a385dbccb672bf7d0a69d6432a1c22 100644 (file)
@@ -3331,8 +3331,8 @@ package Sem_Util is
    function Validated_View (Typ : Entity_Id) return Entity_Id;
    --  Obtain the "validated view" of arbitrary type Typ which is suitable for
    --  verification by attribute 'Valid_Scalars. This view is the type itself
-   --  or its full view while stripping away concurrency, derivations, and
-   --  privacy.
+   --  or its full view or nonlimited view, while stripping away concurrency,
+   --  derivations, and privacy.
 
    function Visible_Ancestors (Typ : Entity_Id) return Elist_Id;
    --  [Ada 2012:AI-0125-1]: Collect all the visible parents and progenitors