iio: light: iqs621-als: prefer early error handling over if (!ret)

Handle errors as early as possible by replacing 'if (!ret)' with the
more common form 'if (ret)'. This makes the code easier to read.

Signed-off-by: Pedro Barletta Gennari <pedro.pbg@usp.br>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

diff --git a/drivers/iio/light/iqs621-als.c b/drivers/iio/light/iqs621-als.c
index 25a655b328fcf7c6e2df8349fcba1ebbb4511999..cd5843e3e2c33845488e8fe9d5c2d45725c77a2d 100644 (file)
--- a/drivers/iio/light/iqs621-als.c
+++ b/drivers/iio/light/iqs621-als.c
@@ -273,18 +273,22 @@ static int iqs621_als_write_event_config(struct iio_dev *indio_dev,
                                         iqs62x->dev_desc->als_mask,
                                         iqs621_als->range_en || state ? 0 :
                                                                         0xFF);
-               if (!ret)
-                       iqs621_als->light_en = state;
-               return ret;
+               if (ret)
+                       return ret;
+               iqs621_als->light_en = state;
+
+               return 0;
 
        case IIO_INTENSITY:
                ret = regmap_update_bits(iqs62x->regmap, IQS620_GLBL_EVENT_MASK,
                                         iqs62x->dev_desc->als_mask,
                                         iqs621_als->light_en || state ? 0 :
                                                                         0xFF);
-               if (!ret)
-                       iqs621_als->range_en = state;
-               return ret;
+               if (ret)
+                       return ret;
+               iqs621_als->range_en = state;
+
+               return 0;
 
        case IIO_PROXIMITY:
                ret = regmap_read(iqs62x->regmap, IQS622_IR_FLAGS, &val);
@@ -295,9 +299,11 @@ static int iqs621_als_write_event_config(struct iio_dev *indio_dev,
                ret = regmap_update_bits(iqs62x->regmap, IQS620_GLBL_EVENT_MASK,
                                         iqs62x->dev_desc->ir_mask,
                                         state ? 0 : 0xFF);
-               if (!ret)
-                       iqs621_als->prox_en = state;
-               return ret;
+               if (ret)
+                       return ret;
+               iqs621_als->prox_en = state;
+
+               return 0;
 
        default:
                return -EINVAL;