]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[#488,!259] Rename parameters in the base network parser.
authorMarcin Siodelski <marcin@isc.org>
Wed, 6 Mar 2019 15:44:29 +0000 (16:44 +0100)
committerMarcin Siodelski <marcin@isc.org>
Thu, 7 Mar 2019 13:00:36 +0000 (08:00 -0500)
src/lib/dhcpsrv/parsers/base_network_parser.cc
src/lib/dhcpsrv/parsers/base_network_parser.h

index 01f74ff490dd638167e138b670d979678897e55a..a48299a0daf507f8ee894e5eff5aa84f276d9faa 100644 (file)
@@ -16,41 +16,41 @@ namespace isc {
 namespace dhcp {
 
 void
-BaseNetworkParser::parseCommonTimers(const ConstElementPtr& shared_network_data,
+BaseNetworkParser::parseCommonTimers(const ConstElementPtr& network_data,
                                      NetworkPtr& network) {
     Triplet<uint32_t> t1;
-    if (shared_network_data->contains("renew-timer")) {
-        network->setT1(getInteger(shared_network_data, "renew-timer"));
+    if (network_data->contains("renew-timer")) {
+        network->setT1(getInteger(network_data, "renew-timer"));
     }
 
     Triplet<uint32_t> t2;
-    if (shared_network_data->contains("rebind-timer")) {
-        network->setT2(getInteger(shared_network_data, "rebind-timer"));
+    if (network_data->contains("rebind-timer")) {
+        network->setT2(getInteger(network_data, "rebind-timer"));
     }
 
     Triplet<uint32_t> valid;
-    if (shared_network_data->contains("valid-lifetime")) {
-        network->setValid(getInteger(shared_network_data, "valid-lifetime"));
+    if (network_data->contains("valid-lifetime")) {
+        network->setValid(getInteger(network_data, "valid-lifetime"));
     }
 }
 
 void
-BaseNetworkParser::parseTeePercents(const ConstElementPtr& shared_network_data,
+BaseNetworkParser::parseTeePercents(const ConstElementPtr& network_data,
                                     NetworkPtr& network) {
     bool calculate_tee_times = network->getCalculateTeeTimes();
-    if (shared_network_data->contains("calculate-tee-times")) {
-        bool calculate_tee_times = getBoolean(shared_network_data, "calculate-tee-times");
+    if (network_data->contains("calculate-tee-times")) {
+        bool calculate_tee_times = getBoolean(network_data, "calculate-tee-times");
         network->setCalculateTeeTimes(calculate_tee_times);
     }
 
     Optional<double> t2_percent;
-    if (shared_network_data->contains("t2-percent")) {
-        t2_percent = getDouble(shared_network_data, "t2-percent");
+    if (network_data->contains("t2-percent")) {
+        t2_percent = getDouble(network_data, "t2-percent");
     }
 
     Optional<double> t1_percent;
-    if (shared_network_data->contains("t1-percent")) {
-        t1_percent = getDouble(shared_network_data, "t1-percent");
+    if (network_data->contains("t1-percent")) {
+        t1_percent = getDouble(network_data, "t1-percent");
     }
     if (calculate_tee_times) {
         if (!t2_percent.unspecified() && ((t2_percent.get() <= 0.0) ||
index 8f3862f43bd9c8f748c36a0f8ca1a8deda08e2d2..61cadf287c6a61e248f3f17d25ab23bc45ebb039 100644 (file)
@@ -30,7 +30,7 @@ protected:
     /// configuration to be parsed.
     /// @param [out] network Pointer to a network in which parsed data is
     /// to be stored.
-    void parseCommonTimers(const data::ConstElementPtr& shared_network_data,
+    void parseCommonTimers(const data::ConstElementPtr& network_data,
                            NetworkPtr& network);
 
     /// @brief Parses parameters related to "percent" timers settngs.
@@ -40,14 +40,14 @@ protected:
     /// - t1-percent,
     /// - t2-percent.
     ///
-    /// @param shared_network_data Data element holding shared network
+    /// @param network_data Data element holding shared network
     /// configuration to be parsed.
     /// @param [out] network Pointer to a network in which parsed data is
     /// to be stored.
     ///
     /// @throw DhcpConfigError if configuration of these parameters is
     /// invalid.
-    void parseTeePercents(const data::ConstElementPtr& shared_network_data,
+    void parseTeePercents(const data::ConstElementPtr& network_data,
                           NetworkPtr& network);
 };