]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
libblkid: fix probe_ddf() [clang-analyze]
authorKarel Zak <kzak@redhat.com>
Tue, 1 Jul 2014 10:32:25 +0000 (12:32 +0200)
committerKarel Zak <kzak@redhat.com>
Tue, 1 Jul 2014 10:32:25 +0000 (12:32 +0200)
Signed-off-by: Karel Zak <kzak@redhat.com>
libblkid/src/superblocks/ddf_raid.c

index b907a9f8cedfc0ef9effa923284280a43bb7da9e..fc2c39d3e597f4302f22c968f274b4e4c4dec1ca 100644 (file)
@@ -110,12 +110,11 @@ static int probe_ddf(blkid_probe pr,
 
                buf = blkid_probe_get_buffer(pr,
                                        lba << 9, sizeof(ddf->signature));
-               if (!buf) {
-                       if (errno)
-                               return -errno;
-                       if (memcmp(buf, &ddf->signature, 4))
-                               return 1;
-               }
+               if (!buf)
+                       return errno ? -errno : 1;
+
+               if (memcmp(buf, &ddf->signature, 4) != 0)
+                       return 1;
        }
 
        blkid_probe_strncpy_uuid(pr, ddf->guid, sizeof(ddf->guid));