media: i2c: imx214: Verify chip ID

Check the chip ID and stop probing if it is no imx214 sensor.

Acked-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: André Apitzsch <git@apitzsch.eu>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index 9de347c533e8d6d4be6e3445014967606466392d..a40875e78127a1352c265780cc6e6644a799f1b2 100644 (file)
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c
@@ -20,6 +20,10 @@
 #include <media/v4l2-fwnode.h>
 #include <media/v4l2-subdev.h>
 
+/* Chip ID */
+#define IMX214_REG_CHIP_ID             CCI_REG16(0x0016)
+#define IMX214_CHIP_ID                 0x0214
+
 #define IMX214_REG_MODE_SELECT         CCI_REG8(0x0100)
 #define IMX214_MODE_STANDBY            0x00
 #define IMX214_MODE_STREAMING          0x01
@@ -1101,6 +1105,27 @@ static int imx214_get_regulators(struct device *dev, struct imx214 *imx214)
                                       imx214->supplies);
 }
 
+/* Verify chip ID */
+static int imx214_identify_module(struct imx214 *imx214)
+{
+       struct i2c_client *client = v4l2_get_subdevdata(&imx214->sd);
+       int ret;
+       u64 val;
+
+       ret = cci_read(imx214->regmap, IMX214_REG_CHIP_ID, &val, NULL);
+       if (ret)
+               return dev_err_probe(&client->dev, ret,
+                                    "failed to read chip id %x\n",
+                                    IMX214_CHIP_ID);
+
+       if (val != IMX214_CHIP_ID)
+               return dev_err_probe(&client->dev, -EIO,
+                                    "chip id mismatch: %x!=%llx\n",
+                                    IMX214_CHIP_ID, val);
+
+       return 0;
+}
+
 static int imx214_parse_fwnode(struct device *dev)
 {
        struct fwnode_handle *endpoint;
@@ -1194,6 +1219,10 @@ static int imx214_probe(struct i2c_client *client)
         */
        imx214_power_on(imx214->dev);
 
+       ret = imx214_identify_module(imx214);
+       if (ret)
+               goto error_power_off;
+
        ret = imx214_ctrls_init(imx214);
        if (ret < 0)
                goto error_power_off;