Bug 2518: assertion failed: comm.cc:1519: "F->flags.open"

Not seen in a while. I suspect its hiding behind a fixed F->closing()
test, so the whole if test may be obsolete.

Applying in order to close the bug with surety and sync the conditions on
shutdown and restart-closing.

diff --git a/src/comm.cc b/src/comm.cc
index 4bb5e9869236527c3c2e6d777bad2157a4b33eae..707b53d611917789eab1c637f2700d320fa1b67a 100644 (file)
--- a/src/comm.cc
+++ b/src/comm.cc
@@ -1513,7 +1513,8 @@ _comm_close(int fd, char const *file, int line)
     if (F->flags.closing)
         return;
 
-    if (shutting_down && (!F->flags.open || F->type == FD_FILE))
+    /* XXX: is this obsolete behind F->closing() ? */
+    if ( (shutting_down || reconfiguring) && (!F->flags.open || F->type == FD_FILE))
         return;
 
     assert(F->flags.open);