media: nxp: imx8-isi: Simplify a couple of error messages

The error messages in the mxc_isi_crossbar_enable_streams() and
mxc_isi_crossbar_disable_streams() functions are similar, with a single
word difference between them. The word is moved out of the format string
to a separate dev_err() argument to try and save memory through string
de-duplication. The total savings are however small, as the .data size
reduction is partly offset by a .text size increase, with a total saving
of 8 bytes in total on an ARM64 platforms. They also come at the cost of
making the error message difficult to grep, which outweights the gains.

Simplify the error messages to make them grep-able.

Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/m3plgi9pwu.fsf@t19.piap.pl
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
index 93a55c97cd1738f72a34b11c2fee5cc2e3c6f6ca..b6c7f114f9edb79e3cb9b1f4ada9b56d251bb967 100644 (file)
--- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
+++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
@@ -352,9 +352,8 @@ static int mxc_isi_crossbar_enable_streams(struct v4l2_subdev *sd,
                                                 sink_streams);
                if (ret) {
                        dev_err(xbar->isi->dev,
-                               "failed to %s streams 0x%llx on '%s':%u: %d\n",
-                               "enable", sink_streams, remote_sd->name,
-                               remote_pad, ret);
+                               "failed to enable streams 0x%llx on '%s':%u: %d\n",
+                               sink_streams, remote_sd->name, remote_pad, ret);
                        mxc_isi_crossbar_gasket_disable(xbar, sink_pad);
                        return ret;
                }
@@ -392,9 +391,8 @@ static int mxc_isi_crossbar_disable_streams(struct v4l2_subdev *sd,
                                                  sink_streams);
                if (ret)
                        dev_err(xbar->isi->dev,
-                               "failed to %s streams 0x%llx on '%s':%u: %d\n",
-                               "disable", sink_streams, remote_sd->name,
-                               remote_pad, ret);
+                               "failed to disable streams 0x%llx on '%s':%u: %d\n",
+                               sink_streams, remote_sd->name, remote_pad, ret);
 
                mxc_isi_crossbar_gasket_disable(xbar, sink_pad);
        }