]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Fix crash at the end of migration
authorJiri Denemark <jdenemar@redhat.com>
Thu, 17 Feb 2022 08:36:48 +0000 (09:36 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Thu, 17 Feb 2022 09:17:19 +0000 (10:17 +0100)
The destination daemon would crash in Finish phase due to NULL
dereference which I missed in my review of commit
v8.0.0-428-g0301db44e2

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_migration.c

index fea5e71f4d442f6099cc1fd7ad1fec08ff85c053..5aecdddff06ba71b63ee88c72fcd9d699f9450d2 100644 (file)
@@ -5855,7 +5855,7 @@ qemuMigrationDstFinish(virQEMUDriver *driver,
         if (jobData) {
             priv->job.completed = g_steal_pointer(&jobData);
             priv->job.completed->status = VIR_DOMAIN_JOB_STATUS_COMPLETED;
-            qemuDomainJobSetStatsType(jobData,
+            qemuDomainJobSetStatsType(priv->job.completed,
                                       QEMU_DOMAIN_JOB_STATS_TYPE_MIGRATION);
         }