]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[#1040] address review
authorRazvan Becheriu <razvan@isc.org>
Fri, 24 Jan 2020 12:11:50 +0000 (14:11 +0200)
committerRazvan Becheriu <razvan@isc.org>
Fri, 24 Jan 2020 12:27:09 +0000 (12:27 +0000)
src/lib/dhcpsrv/alloc_engine.cc

index f0514aebf3b74aa7d70903850068ac6f27aa179d..5c2a1e6883925a9d60a4e029ab8e62778628325c 100644 (file)
@@ -1475,6 +1475,8 @@ AllocEngine::removeNonmatchingReservedLeases6(ClientContext6& ctx,
         // Remove this lease from LeaseMgr as it is reserved to someone
         // else or doesn't belong to a pool.
         if (!LeaseMgrFactory::instance().deleteLease(candidate)) {
+            // Concurrent delete performed by other instance which should
+            // properly handle dns and stats updates.
             continue;
         }
 
@@ -1520,6 +1522,8 @@ AllocEngine::removeNonmatchingReservedNoHostLeases6(ClientContext6& ctx,
 
         // Remove this lease from LeaseMgr as it doesn't belong to a pool.
         if (!LeaseMgrFactory::instance().deleteLease(candidate)) {
+            // Concurrent delete performed by other instance which should
+            // properly handle dns and stats updates.
             continue;
         }
 
@@ -1589,6 +1593,8 @@ AllocEngine::removeNonreservedLeases6(ClientContext6& ctx,
         // We have reservations, but not for this lease. Release it.
         // Remove this lease from LeaseMgr
         if (!LeaseMgrFactory::instance().deleteLease(*lease)) {
+            // Concurrent delete performed by other instance which should
+            // properly handle dns and stats updates.
             continue;
         }
 
@@ -1991,6 +1997,8 @@ AllocEngine::extendLease6(ClientContext6& ctx, Lease6Ptr lease) {
 
         // Remove this lease from LeaseMgr
         if (!LeaseMgrFactory::instance().deleteLease(lease)) {
+            // Concurrent delete performed by other instance which should
+            // properly handle dns and stats updates.
             return;
         }