netfilter: nftables: fix a warning message in nf_tables_commit_audit_collect()

commit dadf33c9f6b5f694e842d224a4d071f59ac665ee upstream.

The first argument of a WARN_ONCE() is a condition.  This WARN_ONCE()
will only print the table name, and is potentially problematic if the
table name has a %s in it.

Fixes: c520292f29b8 ("audit: log nftables configuration change events once per table")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index e638e7380e79422292e36cae42b236ec7d4101e0..996f2a90a12c5887bfdb500db8d6e89720f864cb 100644 (file)
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -7828,7 +7828,7 @@ static void nf_tables_commit_audit_collect(struct list_head *adl,
                if (adp->table == table)
                        goto found;
        }
-       WARN_ONCE("table=%s not expected in commit list", table->name);
+       WARN_ONCE(1, "table=%s not expected in commit list", table->name);
        return;
 found:
        adp->entries++;