ALSA: sh: Fix wrong argument order for copy_from_iter()

commit 66a0a2b0473c39ae85c44628d14e4366fdc0aa0d upstream.

Fix a brown paper bag bug I introduced at converting to the standard
iter helper; the arguments were wrongly passed and have to be
swapped.

Fixes: 9b5f8ee43e48 ("ALSA: sh: Use standard helper for buffer accesses")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202412140019.jat5Dofr-lkp@intel.com/
Link: https://patch.msgid.link/20241220114417.5898-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/sound/sh/sh_dac_audio.c b/sound/sh/sh_dac_audio.c
index 5a9f77908a3d2071d5753c4c9300ad63167f47bf..1c1c14708f01812f38e913fdd971a67eaa38aeee 100644 (file)
--- a/sound/sh/sh_dac_audio.c
+++ b/sound/sh/sh_dac_audio.c
@@ -163,7 +163,7 @@ static int snd_sh_dac_pcm_copy(struct snd_pcm_substream *substream,
        /* channel is not used (interleaved data) */
        struct snd_sh_dac *chip = snd_pcm_substream_chip(substream);
 
-       if (copy_from_iter(chip->data_buffer + pos, src, count) != count)
+       if (copy_from_iter(chip->data_buffer + pos, count, src) != count)
                return -EFAULT;
        chip->buffer_end = chip->data_buffer + pos + count;