]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
winbindd: handling missing idmap in getgrgid()
authorStefan Metzmacher <metze@samba.org>
Wed, 22 Jan 2020 17:00:07 +0000 (17:00 +0000)
committerKarolin Seeger <kseeger@samba.org>
Tue, 11 Feb 2020 12:26:52 +0000 (12:26 +0000)
A similar hunk was added via commit
89f753c1fc824fef29aebb7d783ab7e09cd1f04e ("winbind: Use xids2sids in getpwuid"),
but it was missing in commit
e2dda192e7f8b65a5f02120be56cf0f07d03679f ("winbind: Use xids2sids in getgrgid")

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14265

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Feb  5 17:56:58 UTC 2020 on sn-devel-184

(cherry picked from commit 4d0bda9467ac3f45f85f48a281cdb173ce1064eb)

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Tue Feb 11 12:26:52 UTC 2020 on sn-devel-144

source3/winbindd/winbindd_getgrgid.c

index aa99e6e25610afbf53a2e2132d3ba4a729105f84..24d70161770ab47b6d788fd7bda6b75e377a125f 100644 (file)
@@ -79,6 +79,10 @@ static void winbindd_getgrgid_gid2sid_done(struct tevent_req *subreq)
        if (tevent_req_nterror(req, status)) {
                return;
        }
+       if (is_null_sid(state->sid)) {
+               tevent_req_nterror(req, NT_STATUS_NO_SUCH_GROUP);
+               return;
+       }
 
        subreq = wb_getgrsid_send(state, state->ev, state->sid,
                                  lp_winbind_expand_groups());