]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-35356: Fix a possible reference leak in nis.maps(). (GH-10808)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Fri, 30 Nov 2018 08:04:43 +0000 (00:04 -0800)
committerGitHub <noreply@github.com>
Fri, 30 Nov 2018 08:04:43 +0000 (00:04 -0800)
(cherry picked from commit a2e3585e79c93b2372dbad46a744e28fcc6dad6d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Modules/nismodule.c

index 6acab63ddfd7d2d469eff25af11c544cd6d608df..e8caea9c7e8dd32f4116be16e183f00e1b26f6eb 100644 (file)
@@ -405,6 +405,7 @@ nis_maps (PyObject *self, PyObject *args, PyObject *kwdict)
         PyObject *str = PyString_FromString(maps->map);
         if (!str || PyList_Append(list, str) < 0)
         {
+            Py_XDECREF(str);
             Py_DECREF(list);
             list = NULL;
             break;