OtherBill is right: the change to check (fd < 0) makes no sense, because

ap_slack() and make_sock() guarantee that the returned fd >= 0

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@88436 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/main/http_main.c b/src/main/http_main.c
index 6a2abd6790ae76b71b24dbf0c2f9ed956cfc5f94..a3f66bafc9c0ff511a3424d642f31ad441f7f43d 100644 (file)
--- a/src/main/http_main.c
+++ b/src/main/http_main.c
@@ -3548,8 +3548,8 @@ static void setup_listeners(pool *p)
        else {
            ap_note_cleanups_for_socket(p, fd);
        }
-       if (fd >= 0) /* avoid negative offsets ;-) */
-           FD_SET(fd, &listenfds);
+       /* if we get here, (fd >= 0) && (fd < FD_SETSIZE) */
+       FD_SET(fd, &listenfds);
        if (fd > listenmaxfd)
            listenmaxfd = fd;
        lr->fd = fd;