]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
WPS ER: Explicitly clear PSK from stack after use
authorJouni Malinen <j@w1.fi>
Mon, 29 Dec 2014 11:07:00 +0000 (13:07 +0200)
committerJouni Malinen <j@w1.fi>
Mon, 29 Dec 2014 17:44:51 +0000 (19:44 +0200)
There is no need to leave the PSK from temporary Credential structure
that was built in stack after that Credential has been passed to the WPS
module.

Signed-off-by: Jouni Malinen <j@w1.fi>
wpa_supplicant/wps_supplicant.c

index ebbb798b91225d89ec177866362d031de18bc101..22083bd93ffd1842070f94d200b69c8a2b3ddf50 100644 (file)
@@ -1919,6 +1919,7 @@ int wpas_wps_er_set_config(struct wpa_supplicant *wpa_s, const char *uuid,
        u8 addr[ETH_ALEN], *use_addr = NULL;
        struct wpa_ssid *ssid;
        struct wps_credential cred;
+       int ret;
 
        if (uuid_str2bin(uuid, u) == 0)
                use_uuid = u;
@@ -1932,7 +1933,9 @@ int wpas_wps_er_set_config(struct wpa_supplicant *wpa_s, const char *uuid,
 
        if (wpas_wps_network_to_cred(ssid, &cred) < 0)
                return -1;
-       return wps_er_set_config(wpa_s->wps_er, use_uuid, use_addr, &cred);
+       ret = wps_er_set_config(wpa_s->wps_er, use_uuid, use_addr, &cred);
+       os_memset(&cred, 0, sizeof(cred));
+       return ret;
 }