]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
brcmfmac: Fix memory leak in brcmf_usbdev_qinit
authorNavid Emamdoost <navid.emamdoost@gmail.com>
Sun, 15 Dec 2019 01:51:14 +0000 (19:51 -0600)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 22 May 2020 20:19:20 +0000 (21:19 +0100)
commit 4282dc057d750c6a7dd92953564b15c26b54c22c upstream.

In the implementation of brcmf_usbdev_qinit() the allocated memory for
reqs is leaking if usb_alloc_urb() fails. Release reqs in the error
handling path.

Fixes: 71bb244ba2fd ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/brcm80211/brcmfmac/usb.c

index 8683f4f39539d562c5f6bf18ba188dd939770f12..a31458c6f7a300e9171e58be6b751077dde1c72d 100644 (file)
@@ -365,6 +365,7 @@ fail:
                        usb_free_urb(req->urb);
                list_del(q->next);
        }
+       kfree(reqs);
        return NULL;
 
 }